Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Move variables back to top of version.php file to fix WPCLI #396
WPCLI only fetches the first 2048 bytes of the version file with file_get_contents and so is returning invalid versions.
Motivation and context
How has this been tested?
Tested against latest develop branch
Types of changes
Thanks for the PR!
I was curious about a few more details. I found that WP-CLI extracts the following variables from the
Our explanatory comment for the
So, with this change, all variables that WP-CLI tries to read are successfully parsed.
nylen left a comment
This will be in our next release (1.0.1, no date set yet) and also in tomorrow's nightly build (https://github.com/ClassyBot/ClassicPress-nightly/releases/tag/1.0.0+nightly.20190306, will appear at midnight UTC).