Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-r43581: TinyMCE: remove stray CSS map reference from `skin.min.css`. #412

Merged
merged 1 commit into from Jun 18, 2019

Conversation

@nylen
Copy link
Member

commented Apr 15, 2019

This was causing a warning reported in Slack:

The style sheet located at /wp-includes/js/tinymce/skins/lightgray/skin.min.css is minified, so, it's has a source map reference at the end
/*# sourceMappingURL=skin.min.css.map */
Because the source map file doesn't exist it's throwing an error in Firefox (probably others, as well)

Source map error: request failed with status 404
Resource URL: https://localhost/ClassicPress/wp-includes/js/tinymce/skins/lightgray/skin.min.css?wp-mce-4800-20180716-tadv-4.7.13
Source Map URL: skin.min.css.map

Fixed upstream, see: https://core.trac.wordpress.org/ticket/44785#comment:5

This PR merges https://core.trac.wordpress.org/changeset/43581 / WordPress/wordpress-develop@28dcba3 to ClassicPress.

@johnalarcon
Copy link
Contributor

left a comment

Looks good... thanks for incorporating this!

@nylen

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

Sure thing... the Travis build is going to need some fixing before we can merge it though (see #413). In this case I know the failure is unrelated, but we don't need this urgently so let's not merge anything with a failing build.

@johnalarcon

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

That sounds like a good plan. Thanks for the update.

@nylen nylen force-pushed the merge/wp-r43581 branch from baaf621 to 9949288 Jun 17, 2019

@nylen nylen added this to the Future: v1.0.2 or v1.1.0 milestone Jun 17, 2019

@nylen

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

The build is fixed now, so I'm merging this. It's set for the next minor release which will be out sometime in June or July.

@nylen nylen merged commit 83f5e1a into develop Jun 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nylen nylen deleted the merge/wp-r43581 branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.