Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix strict PHP notice about passing pointers instead of variables. #429
Fix strict PHP notice about passing references instead of variables. Also moves the
Motivation and context
Types of changes
nylen left a comment
Thanks for the PR!
This is a good example of why it's a good idea to add an automated test for any new code. This would have caught this error by executing the code in question against all of our supported PHP versions automatically, and failing if any notices or any other errors occur.
I've added a test case now, and I will merge this once the build finishes again.