Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #404 (https://github.com/ClassicPress/ClassicPress/issu… #434

Merged
merged 1 commit into from Jul 2, 2019

Conversation

@marodok
Copy link
Contributor

commented Jul 1, 2019

Removed "role" tag for valid HTML5 markup

Description

Removed "role" tag for valid HTML5 markup, this changed was made in the file ./wp-includes/link-template.php at line 2586

Motivation and context

It's a fix for issue #404

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@nylen nylen added this to the v1.1.0 milestone Jul 2, 2019

@nylen

nylen approved these changes Jul 2, 2019

Copy link
Member

left a comment

Looks good to me, thanks for the PR!

@nylen nylen merged commit a2eb113 into ClassicPress:develop Jul 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.