Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #445 - Update tweemoji url in gruntfile #446

Merged
merged 3 commits into from Jul 14, 2019

Conversation

@Mte90
Copy link
Collaborator

commented Jul 11, 2019

Description

Fix #445

Motivation and context

The url is in 404 because the project changed the way how to manage assets

How has this been tested?

Locally the grunt task is not getting any issue anymore. Require further testing to see if the there are other errors.

Screenshots (if appropriate):

Screenshot_20190711_124143

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Mte90 and others added some commits Jul 11, 2019

@nylen

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

Thanks for the PR, but I'm seeing an error locally.

$ svn ls https://github.com/twitter/twemoji.git/branches/gh-pages/2/svg
svn: E160016: Can't get entries of non-directory
$ svn ls https://github.com/twitter/twemoji/branches/gh-pages/2/svg
(works)

I made this change. Hopefully the build will pass now, I'll merge the PR when it does.

@nylen

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

src/wp-includes/formatting.php was also corrupted after this change because the script was expecting a list of .ai files but now it gets .svg instead. We need a better way of doing this, see #447. Should be fixed for now though.

@nylen nylen merged commit 6149791 into ClassicPress:develop Jul 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mte90

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 14, 2019

I tested it locally and the grunt task was working fine and I wasn't sure if with this files there was something else processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.