Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelogs info #449 #452

Merged
merged 6 commits into from Aug 1, 2019

Conversation

@bahiirwa
Copy link
Contributor

commented Jul 19, 2019

Add changelog notes in about.php

Description

PR for #449

Motivation and context

Add links and information to explain CP changes and new features in new releases.

How has this been tested?

This is markup and has non-breaking changes. Code has been tested with Code standards and visually.

Screenshots (if appropriate):

Screen Shot 2019-07-19 at 12 16 58

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
@Mte90

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

We didn't defined where show that, the original ticket #449 say in the dashboard and this will be shown on the bottom in the about page.
I think that is better to put on top that is more easy to find.

@bahiirwa

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Honestly, I think changelog deserves its own tab as it can grow. That would be a better option. But James might have a reason as there will be a different approach after 1.1.0

@Mte90

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

there is #422 for that as we said at the last meeting

@nylen

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Changelogs are in order from newest to oldest so the ClassicPress changes should go above the WordPress changes.

Adding a new tab would be something to consider for after we have the full changelogs in the dashboard, but not for now. We'd probably need to change the content in the About tab in order to make this work well, and in general it's not a good idea to make large changes like that close to a release.

Proper hierarchy for changelogs
Move CP changelogs above WP.
@bahiirwa

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

Changelogs are in order from newest to oldest so the ClassicPress changes should go above the WordPress changes.

Change made to this effect.

Adding a new tab would be something to consider for after we have the full changelogs in the dashboard, but not for now. We'd probably need to change the content in the About tab in order to make this work well, and in general it's not a good idea to make large changes like that close to a release.

Noted

@nylen

nylen approved these changes Aug 1, 2019

Copy link
Member

left a comment

This is looking good. I've pushed some minor text updates and this can be merged after the new build passes.

@nylen nylen merged commit 390567e into ClassicPress:develop Aug 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bahiirwa bahiirwa deleted the bahiirwa:about branch Aug 1, 2019

@nylen nylen added this to the v1.1.0 milestone Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.