Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build scripts #455

Merged
merged 5 commits into from Aug 1, 2019

Conversation

@C-Lodder
Copy link
Contributor

commented Jul 24, 2019

Just some updates to the build scripts:

  1. Convert to ES6
  2. Replace grunt-postcss with @lodder/grunt-postcss (see note below)
  3. Move browser list to .browserslistrc in conjunction with the PostCSS update

Point 2 is not at all supposed to be any form of personal endorsement. I forked the original grunt-postcss package and took on maintanence.

Charlie Lodder added some commits Jul 24, 2019

@nylen

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

What is the difference between grunt-postcss and @lodder/grunt-postcss?

Please look into the build failures here, also the indentation in the JS files should be tabs instead of spaces.

C-Lodder added some commits Jul 26, 2019

@C-Lodder

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

@nylen grunt-postcss is no longer maintained and people were moaning that it was using older dependencies.

@lodder/grunt-postcss is my own fork which is still maintained. You can see the change log since I've taken it on here: https://github.com/C-Lodder/grunt-postcss/blob/master/CHANGELOG#L1-L40

@C-Lodder

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

@nylen fixed

@nylen

nylen approved these changes Aug 1, 2019

Copy link
Member

left a comment

I ran the bin/compare-build-branch.sh script against this PR to check for any changes to the built files and there were none. Nice work, and thanks for the updates, including the browserslist config change which had been nagging us in Travis for a while.

@nylen nylen merged commit a4a2b60 into ClassicPress:develop Aug 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.