Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery version after security patch #493

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@mattyrob
Copy link
Contributor

mattyrob commented Sep 18, 2019

Description

Fixes #476

Motivation and context

This updates the jQuery version after applying the latest security fix from WP. The security fix has already been applied in ClassicPress 1.0.1. See #476 for more details.

How has this been tested?

Tested and integrated upstream

Screenshots

N/A

Types of changes

Simple update to jquery version numbers to enable browsers to download fixed versions sooner than current cache expiry.

@nylen nylen changed the title Backport Changeset 45342 Update jQuery version after security patch Sep 18, 2019
@nylen

This comment has been minimized.

Copy link
Member

nylen commented Sep 18, 2019

Note, I've made some edits to the PR title and description, because we've already applied the jQuery security fix itself and shipped it in ClassicPress 1.0.1.

This just needs to be tested on a site to make sure it doesn't break anything (though I think it is fine), we need to confirm the build passes, and that's all.

@nylen nylen added this to the v1.1.0 milestone Sep 18, 2019
@pattonwebz

This comment has been minimized.

Copy link
Contributor

pattonwebz commented Sep 18, 2019

I tested this by requesting a page then checking out this branch and verified it changed the query string changed.

I also verified a 200 status code on the file both requests (and not a 304).

I have not run the build tests to verify this passes.

Looks good to me though :)

@nylen
nylen approved these changes Sep 18, 2019
Copy link
Member

nylen left a comment

Thanks for the PR @mattyrob and for trying it out @pattonwebz.

@nylen nylen merged commit cd28153 into ClassicPress:develop Sep 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mattyrob added a commit to mattyrob/ClassicPress that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.