Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate jQuery version after security patch #493
Conversation
nylen
changed the title
This comment has been minimized.
This comment has been minimized.
|
Note, I've made some edits to the PR title and description, because we've already applied the jQuery security fix itself and shipped it in ClassicPress 1.0.1. This just needs to be tested on a site to make sure it doesn't break anything (though I think it is fine), we need to confirm the build passes, and that's all. |
This comment has been minimized.
This comment has been minimized.
|
I tested this by requesting a page then checking out this branch and verified it changed the query string changed. I also verified a I have not run the build tests to verify this passes. Looks good to me though :) |
|
Thanks for the PR @mattyrob and for trying it out @pattonwebz. |
Fixes ClassicPress#476. Props @mattyrob, @pattonwebz. WP:Props azaozz.
mattyrob commentedSep 18, 2019
•
edited by nylen
Description
Fixes #476
Motivation and context
This updates the jQuery version after applying the latest security fix from WP. The security fix has already been applied in ClassicPress 1.0.1. See #476 for more details.
How has this been tested?
Tested and integrated upstream
Screenshots
N/A
Types of changes
Simple update to jquery version numbers to enable browsers to download fixed versions sooner than current cache expiry.