New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 5.5 and lower #64

Merged
merged 1 commit into from Sep 17, 2018

Conversation

2 participants
@nylen
Copy link
Member

nylen commented Sep 17, 2018

See:

This is an intermediate step to bumping the minimum PHP version to 7.x, which we will be looking at for v2. I would love to go ahead and drop 5.6 now, but 38.3% of all WordPress sites are on it, which to me is way too many people to exclude.

The only immediate effect of this change is that Travis CI builds will now be significantly faster.

We could go ahead and remove some compatibility code for PHP <= 5.5, but I don't really think it's necessary for v1. Let's track that at #63.

To avoid any ill effects from this change, we'll implement a minimum PHP version check in the migration plugin and block the installation for PHP <= 5.5.

@nylen nylen added this to In progress in ClassicPress v1.0.0 via automation Sep 17, 2018

@senlin senlin merged commit e688527 into master Sep 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ClassicPress v1.0.0 automation moved this from In progress to Done Sep 17, 2018

@nylen nylen deleted the remove/php-55-support branch Sep 17, 2018

chiotis added a commit to chiotis/ClassicPress that referenced this pull request Sep 18, 2018

Merge pull request #1 from ClassicPress/master
Drop support for PHP 5.5 and lower (ClassicPress#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment