Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Un-unicode output for Windows CMD #120
All of these "on_appveyor" conditions look like handling only the simple case of Appveyor, and dont really test using green on Windows because there is special logic for Appveyor only.
e.g. I expect that
This is just a general comment, as I realise that this changeset isnt introducing "on_appveyor", but it is making it more "normal" by exposing it as an attribute.
@jayvdb I've reworked the 'flags' inside the module a little to try and make things more explicit.
The test failed on Travis because
The test failed on Appvoyor on a test where colorama is supposed to strip ANSI codes. But the issue is something gets fed a
In any case, the tests do pass on my local machine.