Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF report when exported, does not correctly export as PDF file format (file assoc. issue) #63

Closed
jobannon opened this issue Mar 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jobannon
Copy link

jobannon commented Mar 22, 2022

PDF report when exported does not correctly export as PDF file format (file assoc. issue)

Description

When exporting a PDF report (weekly report for instance), the file is downloaded, but it is not associated by name with. a .pdf file extension type.

Expected behavior

Download a weekly report and have <file_name>.pdf not <file_name> alone.

Currently, this is only problematic on the weekly emailed report, but other reports may exhibit the same behavior.

Screenshots

If applicable, add screenshots to help explain your problem.

Platform

(Please complete the following information)

  • Device: [e.g. Desktop, iPhone X, Pixel 3, etc]
  • OS: [e.g. iOS, macOS, Windows ME]
  • Browser + version [e.g. chrome, safari plus a version]

Additional context

Internal ticket #2994

Internal Pull Request

@jobannon jobannon self-assigned this Mar 23, 2022
@robotdan
Copy link

robotdan commented Apr 1, 2022

@jobannon do you have a PR for -webservice and management-interface as well? Thinking there should be at least one or PR?

@jobannon
Copy link
Author

jobannon commented Apr 4, 2022

@robotdan I tested this locally and only this one change is needed at the API level. After a review, I could not find where webservice and MI would need changes. I think this is the only code that calls generate for our PdfService.

Can think on it a bit, as well...

@robotdan robotdan added the bug Something isn't working label Apr 4, 2022
@robotdan robotdan added this to the 3.32.2 milestone Apr 4, 2022
@robotdan robotdan added this to Code Complete in CleanSpeak Issues Apr 4, 2022
@robotdan robotdan modified the milestones: 3.32.2, 3.33.0 Jun 7, 2022
@robotdan robotdan moved this from Code Complete to Done in CleanSpeak Issues Jun 9, 2022
@robotdan robotdan closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants