-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to implement replacement for using select.poll on macosx #333
Conversation
fizyk
commented
Sep 2, 2019
With using select.select
src/mirakuru/output.py
Outdated
import re | ||
import select | ||
from typing import Union, List, Any, TypeVar, Tuple, IO | ||
|
||
from mirakuru.base import SimpleExecutor | ||
|
||
|
||
IS_DARWIN = platform.system() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comparison?
Can we reliably detect if poll is available? (I remember experiencing some issues with maybe gevent hiding it.) |
@mmaslowskicc It appears to be dependand of the compiler used for macos, if it's gcc, then the poll is available, and the simplest test would be to check for the poll function in select module. (we won't be able to test that on travis though - hence I'm looking for the platform name instead) |
Or we could support choosing any implementation at runtime, and tests would check both. Your approach is ok too, it might fix the problem and keeps the code tested. |