refactor: pass SshHost and password by reference to engine functions#132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the SSH and SFTP interface functions to consistently use references for host, password, and path parameters, instead of passing owned values. This change improves efficiency by avoiding unnecessary cloning and allocations, and ensures more consistent API usage throughout the codebase. All call sites in the UI and logic layers are updated to match the new function signatures.
API Refactoring and Consistency:
src/sftp_engine.rsandsrc/ssh_engine.rsnow take parameters as references (e.g.,&SshHost,Option<&str>,&str) instead of owned values, reducing unnecessary cloning and allocations. [1] [2]UI Integration Updates:
src/ui/file_explorer.rsandsrc/ui/docker.rsare updated to pass references and use.as_deref()for optional passwords, ensuring compatibility with the new function signatures. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Authentication Handling:
establish_ssh_session. [1] [2]Overall, these changes make the codebase more efficient and idiomatic by leveraging references and reducing unnecessary data copying, while also simplifying the integration points in the UI code.