New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nodegit with isomorphic-git #236

Closed
hsablonniere opened this Issue Jul 12, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@hsablonniere
Member

hsablonniere commented Jul 12, 2018

The nodegit situation

The native nodegit dependency creates lots of problem for us:

  • We have to limit node version to 8.3.0
  • We have to ship a nodegit.node file with the binary created by pkg
  • We had to store those binaries in the repo
  • We had to stop the classic npm install and the update system to simplify support.
  • We have problems when people want to build the clever-tools for ARM
  • We have problems on some distro with some GNU tls dep
  • We need to install stuffs on Travis and Jenkins to buil
  • ...

Replacing nodegit with isomorphic-git

The isomorphic-git project is simple git client 100% implemented in JS. Since we have a very limited usage of git, this simple client is a very good match for us.

There are a few things missing in this project that we need to be 100% iso with what we used from nodegit:

PR and issues that could be solved and closed with this:

@hsablonniere

This comment has been minimized.

Member

hsablonniere commented Aug 3, 2018

Hey @divarvel @ptitfred @luisRubiera @jeanBaptisteCaron @FGRibreau

We have a beta version, if you have time to try it, it would be awesome!

  • It does not use nodegit
  • The process will always exit 1 if there is an error

Artifacts are available here:
https://ki2zrw1f1h-jenkins.services.clever-cloud.com/job/clever-tools/16/

@hsablonniere hsablonniere added this to the 1.0.0 milestone Aug 3, 2018

@hsablonniere

This comment has been minimized.

Member

hsablonniere commented Aug 21, 2018

Ping @divarvel @ptitfred @luisRubiera @jeanBaptisteCaron @FGRibreau

Have you had time to test the beta version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment