Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reagents: Component (consumable) Qualities #11051

Closed
Barhandar opened this issue Jan 30, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@Barhandar
Copy link
Contributor

commented Jan 30, 2015

Unlike qualities, they should be internal and implicit, not exposed.

For example, sugar/honey in recipes. Sugar has "reagent": [["sweetness", 2]], honey has "reagent": [["sweetness", 1]]. A recipe calls for "reagents": [["sweetness", 4]]/{ "reagent": "sweetness", "amount": 4" }. The resulting recipe in-game display, therefore, is: > up to 2 sugar AND/OR up to 4 honey along with the rest of components, with the requred item list being made by the code on load and cached.

Essentially, for player it should look (mostly) the same as if the regular component list was used, while files specify reagents instead.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@illi-kun

This comment has been minimized.

Copy link
Member

commented Nov 18, 2016

This issue was closed as it appears inactive.

Reducing open issues to those which are (or will) be actively worked upon helps us focus our efforts. This issue has not been deleted - it still appears in searches and if it contains relevant information you are encouraged to continue to link to it.

If this issue was a bug

It should be reopened if it can be reproduced in the current build. You can obtain the most recent copy here. Please check there is not a more recent report of this bug before doing so. If no more recent report exists you should continue the discussion in this issue.

If this was a feature request

If the consensus was that the idea was good you could consider submitting an implementation via a PR. If you want to comment further please do so here as opposed to opening a new issue. Before posting check nobody has already made the same point and consider whether your comments are likely to lead to an implementation. If you have doubts about either consider instead voting for the issue

If you want to work on this issue

Then either assign it to yourself or if you are unable to do so claim it via adding a comment. Please don't assign others or make a general request for action.

@illi-kun illi-kun closed this Nov 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.