Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info about boots' ability to hold knives #11560

Closed
Night-Pryanik opened this issue Mar 13, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@Night-Pryanik
Copy link
Member

commented Mar 13, 2015

I think we should give information to players about boots' ability to hold knives in item description. I played a lot and learned about it totally by chance (looking at second screenshot at this (http://smf.cataclysmdda.com/index.php?topic=5745.msg226556#msg226556) post) because there is no other source of information about it.
3 variants of doing it:

  • Manually add text like "You can hold a knife in this footwear" to every footwear description;
  • Make a flag like [BOOTS] and add aforementioned text to this flag, then add this flag to all appropriate footwear;
  • Add check for iuse_function_list["BOOTS"] or iuse::boots (don't know what is better and if it even possible) in item.cpp with aforementioned text.
@graysage1

This comment has been minimized.

Copy link

commented Mar 13, 2015

Yes please, assuming that screen cap isn't a fluke, lol. In general informing the player seems to be a recurrent theme in some of these issues.

Can all boots do this or just the military?

@Night-Pryanik

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2015

All boots with "use_action" : "BOOTS" string in item.cpp can do this.
I made it myself by going the second way (made a flag "BOOTS", then added this flag to all appropriate footwear, then added text with check for this flag in item.cpp). PR'ed (#11566)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.