Bright as day during the night

[Izicata]

Once the day to night dimming effect has finished, the light level will snap back to full-daylight, as if it were still day. When the sun rises, the light level snaps to full darkness , then the night-to-day undimming effect occurs.

[ethankaminski]

Seems to be reproducible, but not necessarily reliably. I've also only seen it with non-default start times.

[Stevensonz]

yeah when I play with time not as default it will do it 100% of the time and mess-up with sleeping unless your underground.

[kevingranade]

Did some debugging on this, probably related so some changes I made to
game::light_level(), which seems to be returning 255, but I'm not at all
sure how that's happening, probably just missing something dumb in there.
On Jun 4, 2013 6:47 PM, "Izicata" notifications@github.com wrote:

Once the day to night dimming effect has finished, the light level will
snap back to full-daylight, as if it were still day. When the sun rises,
the light level snaps to full darkness , then the night-to-day undimming
effect occurs.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1381
.

[Stevensonz]

Made the start time default again but bug still happens no matter what starting time. It's a bit hard to sleep right now unless you sleep in a basement because of the light that wakes you up.

[kevingranade]

Oh.. that's it...
When sunlight reaches 0, and weather.light_modifier is 2+ (cloudy, hence
why it didn't always happen), the value is -1, which is cast to unsigned
char when it's returned, which evals to 255.
The blame is mine, commit 28b1bb5 accidentally removed a if(ret < 1) ret
= 1; check along with some other manipulations.
In my defense that was pretty fragile :P