Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"It will be done in 3 seasons" Eternal seasons messes with delayed_transform message #14675

Closed
chaosvolt opened this issue Dec 31, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@chaosvolt
Copy link
Contributor

commented Dec 31, 2015

wat

Windows tile build 4104, with Eternal Seasons on in winter.

I have no idea if this a display bug, a bug involving delayed transform items in general, or a bizarre interaction with eternal seasons.

If it's already been reported, I will feel silly. ;w;

EDIT: Can confirm it's still FUBAR as of build 4118.

EDIT 2: And can confirm that it behaves sanely with eternal seasons off.

EDIT 3: Welp. Found out that I wasn't waiting long enough.

@chaosvolt chaosvolt changed the title "It will be done in 3 seasons" "It will be done in 3 seasons" Eternal seasons messes with delayed_transform Dec 31, 2015

@DanmakuDan

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2016

Eternal season is overriding the season used when converting the current time into a duration, but the text printout in calendar::textify_period() still sees the winter start as '3 seasons from spring.' From what I can tell, the tanning pelt finishes in 2 days anyway.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2016

Um. Hmm. Are you sure? I could've sworn I waited a while, such that the display should've changed...

@DanmakuDan

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2016

The game knows the timer is set to 2 days, the modification that eternal season does for the current season affects what the game is using to print a text version of the duration.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2016

Hmm. Guess I'll double-check that. Might not've have given it enough time.

@DanmakuDan

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2016

I used the debug menu to fast forward the time by two days when I tested, and the tanning hide description said it was ready.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2016

Hmm. Very odd.

Let me commit some !!SCIENCE!! on this I guess. And I might have to do it the old-fashioned way, debugged "sleep is for the weak" trait plus some waiting.

@chaosvolt chaosvolt changed the title "It will be done in 3 seasons" Eternal seasons messes with delayed_transform "It will be done in 3 seasons" Eternal seasons messes with delayed_transform message Jan 1, 2016

@joneskun

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2016

Check the game log (shift p) for more entertainment. "3 seasons ago..."

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2016

...ow, my sanity.

@chaosvolt

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2016

Derp. I should've commented on or otherwise watched @DanmakuDan's PR fixing this. Sorry about that.

@chaosvolt chaosvolt closed this Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.