Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upEmepty magazines still connected with ammo type and cannot be unloaded #15578
Comments
This comment has been minimized.
This comment has been minimized.
|
Empty magazines are not supposed to be 'one size fits all' kind of devices. |
This comment has been minimized.
This comment has been minimized.
|
It happens even if bullets should fit into magazine. I tested bug with .45 caliber bullets of different types (refited, normal JPH). So then I shot out all of my refited bullets I've got situation then for some reason I can't reload emepty mag with same caliber bullets but with other type (non refited). Magazine remebered that it contained refted bullets and wait EXACTLY THAT type of bullets. After that I couldn't reload it with non refited .45. It is definitely a bug. |
This comment has been minimized.
This comment has been minimized.
|
What are the exact sequence of steps |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
|
Firestorm01X2
changed the title
Emepty magazines still connected with ammo type and cannot be unloaded
Emepty magazines still connected with ammo type and cannot be unloaded ( item::ammo_consume incorrectly retains an empty ammo item with charges == 0))
Feb 27, 2016
Firestorm01X2
changed the title
Emepty magazines still connected with ammo type and cannot be unloaded ( item::ammo_consume incorrectly retains an empty ammo item with charges == 0))
Emepty magazines still connected with ammo type and cannot be unloaded ( item::ammo_consume incorrectly retains an empty ammo item with charges == 0)
Feb 27, 2016
mugling
added a commit
to mugling/Cataclysm-DDA
that referenced
this issue
Feb 27, 2016
mugling
referenced this issue
Feb 27, 2016
Merged
Magazines retain an empty ammo item in error #15581
This comment has been minimized.
This comment has been minimized.
|
@Firestorm01X2 your original title is more concise and therefore preferred |
Firestorm01X2 commentedFeb 27, 2016
If you shoot all bullets from magazine then it will be marked as magazine with zero bullets. But it still will be connected with ammo type that was loaded before.
You can't unload that magazine. And you can't reload it with another type of ammo that fits ino magazine. So if you have no ammo of that type- your magazine will be deadlocked.
Reproducing: