Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emepty magazines still connected with ammo type and cannot be unloaded #15578

Closed
Firestorm01X2 opened this issue Feb 27, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@Firestorm01X2
Copy link
Contributor

commented Feb 27, 2016

If you shoot all bullets from magazine then it will be marked as magazine with zero bullets. But it still will be connected with ammo type that was loaded before.
You can't unload that magazine. And you can't reload it with another type of ammo that fits ino magazine. So if you have no ammo of that type- your magazine will be deadlocked.

Reproducing:

  • Shoot all ammo from magazine (important: shoot out but not unload);
  • Try to load with another type of ammo but with same caliber;
  • You can't do that becuase magazine still remember old type of ammo and and it can't be unloaded, becuse it containts no ammo.
@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2016

Empty magazines are not supposed to be 'one size fits all' kind of devices.

@Firestorm01X2

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2016

It happens even if bullets should fit into magazine. I tested bug with .45 caliber bullets of different types (refited, normal JPH).

So then I shot out all of my refited bullets I've got situation then for some reason I can't reload emepty mag with same caliber bullets but with other type (non refited). Magazine remebered that it contained refted bullets and wait EXACTLY THAT type of bullets. After that I couldn't reload it with non refited .45.
I tried to unload that mag to clear ammo type but emepty magazine cannot be uloaded (that is logical).

It is definitely a bug.

@mugling

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2016

What are the exact sequence of steps

@Firestorm01X2

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2016

  • Take M1911;
  • Take 7 .45 FMJ reifeted bulets and 7 .45 ACP JHP bullets
  • Take emepty magazine .45;
  • Load it with .45 FMJ reifeted;
  • Load magazine into pistol;
  • Shoot out ALL bullets from magazine;
  • Unload emetpy magazine from pistol;
  • Try to load .45 ACP JHP bullets into that magazine;
  • You can't do it becuase mag wait for FMJ reifeted and can be reloaded only with that type of ammo,
  • You can't unload your magazine because it is emepty.
@mugling

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2016

item::ammo_consume incorrectly retains an empty ammo item with charges == 0

@Firestorm01X2 Firestorm01X2 changed the title Emepty magazines still connected with ammo type and cannot be unloaded Emepty magazines still connected with ammo type and cannot be unloaded ( item::ammo_consume incorrectly retains an empty ammo item with charges == 0)) Feb 27, 2016

@Firestorm01X2 Firestorm01X2 changed the title Emepty magazines still connected with ammo type and cannot be unloaded ( item::ammo_consume incorrectly retains an empty ammo item with charges == 0)) Emepty magazines still connected with ammo type and cannot be unloaded ( item::ammo_consume incorrectly retains an empty ammo item with charges == 0) Feb 27, 2016

mugling added a commit to mugling/Cataclysm-DDA that referenced this issue Feb 27, 2016

@mugling

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2016

@Firestorm01X2 your original title is more concise and therefore preferred

@Firestorm01X2 Firestorm01X2 changed the title Emepty magazines still connected with ammo type and cannot be unloaded ( item::ammo_consume incorrectly retains an empty ammo item with charges == 0) Emepty magazines still connected with ammo type and cannot be unloaded Feb 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.