Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting Cooking oil causes the program to become non responsive. #16094

Closed
WizardOfOoo opened this issue Apr 7, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@WizardOfOoo
Copy link
Contributor

commented Apr 7, 2016

0.C-12726-gcfc59e9
Win x64

Save directory:
https://mega.nz/#!qwFlgYoJ!QkVdKwRwRlDdBYY6PX5j9BE-bJzfGwvfW-7MBtORSRw

When I craft cooking oil, it does not show any containers I have in my inventory or nearby. This results in me having to dump the oil on the floor, which crashed the game. I don't get any debug messages.

It does, however show the container if I hold it. If I put it into a held container, ie a gallon jug, I get a "Gallon jug of cooking oil" with no listed amount.

Wishing for cooking oil results in "cooking oil (0)", or "Gallon jug of cooking oil" if I wish for it in a container.

Neither shows up in my crafting menu as usable.

I have tried making a new world with new survivor, same results.

@WizardOfOoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2016

Updated to 0.C-12756-gf2fb560. Tried different PC, same bug, still crashes when I dump the oil.

@WizardOfOoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2016

I bet it has something to do with the strangeness here, as shown in the wish menu and crafting menu. SS's below.

The price and volume are bad, the portion is 0.

I can't find where cooking_oil is in the code, but I bet the .json entry is fine.

As it stands, crafting cooking oil effectively crashes the game.

image

image

@WizardOfOoo WizardOfOoo changed the title Wishing or crafting cooking oil results in "cooking oil (0)" "Gallon jug of cooking oil" Crafting Cooking oil causes the program to become non responsive. Apr 8, 2016

@Zireael07

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2016

Is it the only liquid to have this strangeness?

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2016

I think I found it:

ae7e366 removes charges from cooking oil. Default charges are 0, not 1.

@mugling

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2016

I'm working on a PR that makes charges: 1 the default so that should resolve this issue

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Apr 8, 2016

It's also supposed to be two charges per volume, not one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.