Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic guns broken again #17157

Closed
mugling opened this issue Jun 12, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@mugling
Copy link
Contributor

commented Jun 12, 2016

The JSON load errors can be fixed and the definitions brought in-sync, possibly via the syntax discussed in #14250:

{
    "id": "glock_19",
    "copy-from": "glock_19",
    "type": "GUN",
    "name": "semiautomatic pistol",
    "description": "A typical sidearm for the police, military, and licensed civilians."
},

The question is though is anyone actually using this mod as nobody ever complains upon breakage and I suspect the work going into maintaining it greatly exceeds the maintenance costs.

@pingpong2011

This comment has been minimized.

Copy link

commented Jun 14, 2016

I don't use the mod just because I don't normally use mods, but I might use it if I was sure I could just look at a gun and it says "name" "ammo". The whole point of generic guns would be to limit the, uh, obsession with explicit fancy gun, and even if it changed the names, if I couldn't tell at a glance what the class and ammo is, there's not really a point. "pistol 19mm" would make sense, but "semiautomatic pistol" is useless because it barely tells me anything more than the original name.

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2016

Would make sense to make poll on forums. There are people who don't have github accounts, but post on forums.

@mugling

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2016

I don't have an account. Perhaps someone can post there?

@Coolthulhu

This comment has been minimized.

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2016

@mugling it is easy to create an account on the forums, all you need is a new password and an email account.

@nikheizen

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2016

I use Generic guns with the disabled magazines, even though they are totally broken at present. I would very much like if it could be fixed and may submit a fix myself if I start looking through the code.
If anyone does decide to start maintaining it, I would appreciate ammo counts being lessened. Since all ammo is compatible, you end up getting too much too easily.

@nikheizen nikheizen referenced this issue Jul 1, 2016

Merged

[WIP] Updating and Rewriting Generic_Guns #17471

6 of 6 tasks complete
@mugling

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2016

It's mostly working again now thanks to the effort of @nikheizen

@mugling mugling closed this Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.