Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upGeneric guns broken again #17157
Comments
mugling
added
<Suggestion / Discussion>
[JSON]
Mods
labels
Jun 12, 2016
This comment has been minimized.
This comment has been minimized.
pingpong2011
commented
Jun 14, 2016
|
I don't use the mod just because I don't normally use mods, but I might use it if I was sure I could just look at a gun and it says "name" "ammo". The whole point of generic guns would be to limit the, uh, obsession with explicit fancy gun, and even if it changed the names, if I couldn't tell at a glance what the class and ammo is, there's not really a point. "pistol 19mm" would make sense, but "semiautomatic pistol" is useless because it barely tells me anything more than the original name. |
This comment has been minimized.
This comment has been minimized.
|
Would make sense to make poll on forums. There are people who don't have github accounts, but post on forums. |
This comment has been minimized.
This comment has been minimized.
|
I don't have an account. Perhaps someone can post there? |
This comment has been minimized.
This comment has been minimized.
pingpong2011
referenced this issue
Jun 17, 2016
Closed
Using mods to only modify existing attributes #17230
This comment has been minimized.
This comment has been minimized.
|
@mugling it is easy to create an account on the forums, all you need is a new password and an email account. |
This comment has been minimized.
This comment has been minimized.
|
I use Generic guns with the disabled magazines, even though they are totally broken at present. I would very much like if it could be fixed and may submit a fix myself if I start looking through the code. |
This comment has been minimized.
This comment has been minimized.
|
It's mostly working again now thanks to the effort of @nikheizen |
mugling commentedJun 12, 2016
The JSON load errors can be fixed and the definitions brought in-sync, possibly via the syntax discussed in #14250:
The question is though is anyone actually using this mod as nobody ever complains upon breakage and I suspect the work going into maintaining it greatly exceeds the maintenance costs.