All bullets reflect off NPCs

[bumpkindda]

• Start new game
• Debug skills to 10
• Spawn a Barrett .50 with AP ammo
• Shoot NPC
• Get wrecked by their nail bat

[mugling]

Can reproduce in master

[Coolthulhu]

Can't reproduce here, could be an unspecified behavior kind of a thing.

[CapitalistShrub]

Using unmodded 5062 (15449-gf8f5cd1) I was unable to damage any npc using a Mosin Nagant, a Beretta M9, a Marlin, a Scout Rifle or the Fusion Blaster Arm cbm initial impact (though the fire does kill); shots were taken at various distances, but all were either critical hits or headshots and resulted in "The shot reflects off of" messages.

[CapitalistShrub]

EDIT: This affects the player character too - you can hug a security bot naked and live to tell the tale. We might want to change the title of this issue to reflect that cutting damage isn't applying to the player or NPCs.

A quick update - it looks like NPC's are currently extremely resistant to cutting damage (as in, effectively taking almost none), not only from firearms.

A diamond nodachi on a character with 20 in all stats and 10 in all skills is hitting for 10's and 15's against an npc in light clothing:

That same character using a sledgehammer was able to apply the full damage against an NPC:

[CapitalistShrub]

Cutting damage affects NPC's and the player in build 5032, but does not affect either in 5047. Build 5033 seems the most likely offender due to the changes made to NPC's and damage types, but I'll readily admit that I'm not very familiar with the codebase yet.

My assumption is that either the NPC's and Player are somehow being incorrectly flagged as cut immune, perhaps due to fallback to a default value, or cut damage is being incorrectly zeroed upon application somehow.

Edit: DanmakuDan_ and I found the issue to not be present in the x64 wintiles, but could confirm it in the 32 bit version.

[Coolthulhu]

DanmakuDan_ and I found the issue to not be present in the x64 wintiles, but could confirm it in the 32 bit version.

That sounds like bad news, because it most likely means that an enum or bitset goes out of its allowed range and wraps back.
Or that an invalid cast is being made.

[mugling]

Can reproduce in 64-bit tiles. Presume undefined behavior.

[Coolthulhu]

I think it may be caused by unset values in std::array in resistances.

If this is the case, #17243 would fix it, since it explicitly sets the array to zero.

[mugling]

Indeed fixed by #17243