Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upLiquid duplication when LOOKING at buckets #17341
Comments
Coolthulhu
added
the
unknown
label
Jun 24, 2016
mugling
referenced this issue
Jun 24, 2016
Closed
Turrets clone the shooter, preventing original shooter from being "responsible" #17343
mugling
closed this
in
#17344
Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Coolthulhu commentedJun 24, 2016
Now that's an arcane bug. I'm in the process of fixing it, but I feel the need to report it just as a warning for the future and possible amusement. I had to debug to find it.
The bug is caused because of how we're calculating volume and weight of items to be picked up: we clone the player, give the clone new items and ask how much does the clone's item weight and occupy volume.
But giving any character a bucket with liquid will spill the liquid. This includes the clone who doesn't really exist and will be deleted as soon as the pickup menu is closed.
So by imagining a character who will pick up an item, we create a real copy of said item's contents.