Steel lumps recipe error, requires both chunks and scrap. Not either one of them.

[Soyweiser]

As reported here: http://smf.cataclysmdda.com/index.php?topic=14.msg278075#msg278075

DooMJake: "Is it intentional that in the latest experimantal you need 20 scrap AND 5 chunks of metal to make a lump of steel?"

I cannot find the PR that changed the code. Only this commit: 7434f4b mugling directly changing stuff in the codebase.

Could we please not do that? directly changing stuff in the codebase makes it very hard for people to see what has changed recently. And nobody can check the code for mistakes (all coders make them. We are only human). I thought it was agreed upon that even people like @kevingranade got other people like @Rivet-the-Zombie to look over the stuff they changed. (I could be wrong of course, just correct me if I am).

I have no idea how it is done in other github projects where people write directly to the master btw. I cannot find an easy list of changes to the master. Only closed/open issues and PRs, and well, if you go to the specific users, you can see which commits they pushed. But that doesn't seem like a good way to keep up to date with what changes. Am I missing something?
Duh: https://github.com/CleverRaven/Cataclysm-DDA/commits/master here of course.

[mugling]

I cannot find the PR that changed the code. Only this commit: 7434f4b mugling directly changing stuff in the codebase. Could we please not do that?

That commit (7434f4b) is part of #17303 titled Steel working [CR]

directly changing stuff in the codebase makes it very hard for people to see what has changed recently

This is always helpful https://github.com/CleverRaven/Cataclysm-DDA/pulse and of course the buildbot log here http://ci.narc.ro/view/Cataclysm-DDA/job/Cataclysm-Matrix/changes.

Both include the details as to those changes. You could subscribe for email notifications as well. Finally you could read the JSON where I added inline comments.

nobody can check the code for mistakes... I thought it was agreed upon that even people like @kevingranade got other people like @Rivet-the-Zombie to look over the stuff they changed.

@Rivet-the-Zombie actually helped review that and it was later merged by @Coolthulhu

I could be wrong of course, just correct me if I am

You are. Relatedly, spreading derision on the forums isn't helpful to the project.

[Soyweiser]

And how do I go from this: 7434f4b to the correct pr then? This is how it looked for me on the commit log: http://prntscr.com/bnm8zh

I could not find the pr at all. And I used search to find the recipe, and that linked to the commit above. Not the pr. And that lead me to my conclusion. As I said, I could be wrong.

Didn;t even know you were active on the forums. And yeah, I recently noticed that cdda is implementing a lot of stuff I do find tedious.

[mugling]

And how do I go from this: 7434f4b to the correct pr then?

Pasting the commit checksum into the search box works well. This isn't really Q&A so you can find the answer to further github questions here

Didn;t even know you were active on the forums

You linked to them in this post.

And yeah, I recently noticed that cdda is implementing a lot of stuff I do find tedious.

Issues on github are ideally concise, civil and with a narrow enough scope that they can lead to a PR to close them.

[Soyweiser]

Issues on github are ideally concise, civil and with a narrow enough scope that they can lead to a PR to close them.

I don't mean the issues, that I find tedious. I find the new game mechanics that are implemented tedious. The focus on realism over fun. Sorry for the misunderstanding.

[Leland]

Fixed by #19647