Build failures for Windows on Jenkins

[ghost]

Since build 5178.

In file included from src/player.h:5:0,
                 from src/player.cpp:1:
src/copyable_unique_ptr.h:11:9: error: unused parameter 'rhs' [-Werror=unused-parameter]
         copyable_unique_ptr( copyable_unique_ptr &&rhs ) = default;
         ^
In file included from src/player.cpp:1:0:
src/player.h: In constructor 'player::player(player&&)':
src/player.h:139:7: note: synthesized method 'copyable_unique_ptr<T>::copyable_unique_ptr(copyable_unique_ptr<T>&&) [with T = craft_command]' first required here 
 class player : public Character, public JsonSerializer, public JsonDeserializer
       ^
src/player.cpp: At global scope:
src/player.cpp:294:29: note: synthesized method 'player::player(player&&)' first required here 
 player::player(player &&) = default;
                             ^

[mugling]

Likely fallout from #17434

[kevingranade]

What exactly is the point of a "copyable_unique_ptr"? AFAICT it provides functionality explicitly rejected by the C++ standards committee by the removal of auto_ptr because it was a very error prone way of managing memory.
If you need a unique_ptr in a class that needs to by copyable, you need to resolve that in your copy constructor (yes that means you can't have an implicit copy constructor any more).

[BevapDin]

(yes that means you can't have an implicit copy constructor any more)

And that's where the trouble starts. Who wants to write a copy constructor of player? And who wants to keep it up to date? I remember at least one bug that was caused by not copying a member in the (formerly explicit) copy constructor.

Maybe copyable_unique_ptr is unfortunately named. It is supposed to be a Pimpl wrapper that provides value semantic (copy the referred object, not just the pointer). It's basically used to avoiding including the header for the wrapped type.

[kevingranade]

Does anyone have an environment that can reproduce this? I built on linux with gcc and windiws with mingw, no dice. I hate stabs in the dark, but here they are: The move constructor isn't templated, is that normal? Try making the move constructor explicit.

[ghost]

Now Windows curses passes the build but tiles is still failing.

Fixed in 5194.

[ghost]

Sad, ERR_CONNECTION_RESET to ci.narc.ro.