DEBUG: No TURRET

[woutershep]

Happened twice now, i think ammo spawning code is trying to find a turret to fill but since its busted it breaks.

(No blazemod involved ;))

[ghost]

Confirmed. Met this also in my save in recent days, when traveling to a new city, this could happen occasionally.

[mugling]

Potentially relatedly I'm also struggling to start engines a global_pos3 returns an incorrect location. @Coolthulhu any recent updates to vehicle that could have affected this?

[DangerNoodle]

It seems I have stumbled on the same bug. I am disappointed that no discussion or useful info has developed since the date this was opened.

It would be reasonable to assume that turrets now needing to be explicitly reloaded, and/or the vehicle definitions now defining a random chance of it spawning loaded, are the cause here.

Apologies for my initial post regarding this error being in my report of checking for errors after #18566. That said, it might be good to check whether or not generic tanks are subject to the same potential "error on first encounter" issue, since fuel tanks are now also set to randomly spawn with fuel in the tank.

[hmstanley]

I actually think this is related to the fact that these weapons have modifications on them, - bipod, and I suspect that's the bug. Since you can't mount these on turrets after you remove them from the turret. Only unloaded non modified weapons can exist on turrets.

[DangerNoodle]

But do these mods show up on a weapon by default? As far as i can tell, this is about a debug error occurring when a vehicle first spawns in the reality bubble, so it should have a mounted weapon in default configuration.

[hmstanley]

Right. But, for some reason, the fact that these weapons have integrated bipods screws up the mounting logic methinks. That said, the same doesn't happen for vehicles with .50 or 120mm guns etc. only with 240/249/ m60 all of which have an integrated bipod.

[hmstanley]

I did this experiment. I removed the m249 on the Humvee and then tried to remount it. I couldn't. For any weapon with the bipod. I could do it for weapons without bipods.

[DangerNoodle]

Incorrect. This bug also seems to occur with the tank cannons in Tanks and Other Vehicles mod, which do not come with any gunmods installed.

Bipod anomalies are likely a separate bug.

[hmstanley]

You mean the turret issue. Ok. I didn't test this. But, the fact that the M249 exists on the Humvee and then removing it and trying to add it back results in no joy. It appears that blazemod is not related to this issue tho. I'm gonna test this a little further.

[DangerNoodle]

The issue that is being reported here has been linked to the "define turret as loaded in vehicle definition" changes, as far as can be determined. It only seems to create an error when the vehicle is generated with ammo loaded into it, and with the turret part itself generating broken. The exact cause is likely related to whatever code generates ammo for turrets that spawn loaded, but no one with adequate code experience has put effort into confirming and reporting their findings.

Whatever code that creates this failure is likely unrelated to #18886, this is off-topic.

[hmstanley]

Sorry man. Just thought they were connected. Guess not.

[DangerNoodle]

If a specific pull request changed both sections of code, it is possible. But not likely.

No worries though.

[DangerNoodle]

Is this actually fixed? Can you confirm this?

[kevingranade]

Report on forums that t his continues to occur: http://smf.cataclysmdda.com/index.php?topic=14316

[DangerNoodle]

Peculiar. I will obtain the latest build to further attempt to encounter this error as well.

[DangerNoodle]

Is there any way to force a certain level of vehicle damage when placing a vehicle using mapgen entries? This would permit easier testing, as otherwise occurrence of this error is purely dependent upon random generation. Failing that, increasing the weight of armed vehicles in vehicle groups would work as a way to expedite testing.

Edit, no longer required. Confirmation post shall follow.

[DangerNoodle]

Confirming occurrence of this issue in latest build at time of posting, 0.C-21985-g2ccdd6eefa, or build number 6377.

As I stated in prior post, testing was expedited via increasing the weight of vehicles possessing turrets, then simply wandering through town until an error occurred. World was purely default settings, with only the default mods.

I would assume that @Coolthulhu simply closed accidentally.

[Coolthulhu]

I closed it because an instance of this bug has been fixed and stopped happening. At least I haven't seen it in a long time, while earlier versions had it happen a lot.
The debug message is the same as earlier, but the bug most likely has a different source.

[DangerNoodle]

At least I haven't seen it in a long time, while earlier versions had it happen a lot.

As this bug can only develop under specific random circumstances, the only way to actually confirm if the bug is resolved is to force a given vehicle to spawn with turrets loaded one hundred percent of the time.

Having done so, forcing large numbers to appear in cities will eventually confirm it to be fixed in the event you find one that has generated with a destroyed turret, without having provoked a debug error.

[DangerNoodle]

Additionally, a question. What pull request do you suspect had fixed an earlier instance of this bug? Because no pull request appears to have linked to this issue. And given the nature of this bug, without knowing what attempted to resolve the issue, it remains possible that it was only a gap in confirmation, not a gap in occurrences.

[Coolthulhu]

Because no pull request appears to have linked to this issue.

One of the ranged reworks changed a large part of turret.cpp. Many PRs do not link to relevant issues because digging through 900+ issues with github's wonderful search engine can't be treated as a mandatory requirement.

Many bugs die "on their own", with no explicit fix. If it's hard to reproduce, it usually dies that way.

[DangerNoodle]

That would explain it then. My apologies for that.

[chrBrd]

I've just come across this bug on a self-compiled build of the master branch. It's showing up exactly as it is for DangerNoodle, but the line no. is 4938.