Asking NPCs to teach martial arts causes segmentation faults

[3t3rn4lfl4m3]

Every time I ask an NPC to teach me a martial art they know, I get a segmentation fault. Asking them to teach skills works without problems.

I am playing "Version: 0.6-116-gd1d6525".

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[oddbjol]

Martial arts aren't skills, they're weirdly behaving items. The training code for npcs assigns an ACT_TRAIN task to the player, with a nonexisting skill (the martial art).

I'm sure there's an easy fix for this, but there are issues like this one all over the code. Martial art styles should probably be implemented differently.

[KA101]

Huh. It worked fine for me back in the 02Feb day.

[BevapDin]

No, but that crash might be removed by #5606 (which does not affect this issue).

[mugling]

Much of the NPC code has been rewritten since this was reported nearly 3 years ago. @3t3rn4lfl4m3 please re-open if you can reproduce in any recent version of master