Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digging/mining downstairs fails to generate matching upstairs (even with z-levels on) #18452

Closed
DangerNoodle opened this issue Sep 20, 2016 · 12 comments

Comments

Projects
None yet
6 participants
@DangerNoodle
Copy link
Contributor

commented Sep 20, 2016

Tested in Windows graphical, builds 5464 and 5564 (the latter being latest built at the time of opening this issue).

Creating stairs using the "dig downstairs" or "mine downstairs" constructions do not create an upwards stairway on the floor below. Further tests revealed that enabling z-levels had no effect on this.

stair failure

@DangerNoodle DangerNoodle changed the title Digging downstairs fails to generate matching upstairs Digging/mining downstairs fails to generate matching upstairs (even with z-levels on) Sep 20, 2016

@Rivet-the-Zombie

This comment has been minimized.

Copy link
Member

commented Sep 21, 2016

I wonder when this broke. I can verify that it used to work properly at one point in time.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2016

I sadly have no idea when this was broken. One hundred builds ago is a lot, but not a very long period of time.

@mugling

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2016

Was there not a stair alignment PR?

@DangerNoodle

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2016

That might be a possible cause. I did not think to test whether stair alignment affected it. All tests were done with it disabled, the default setting.

When I encountered this in my current character, I debug-teleported downstairs and spawned a clairvoyance artifact. No upstairs were visible. I then created an upstair with the map editor, and I was able to travel up and down afterward.

@Coolthulhu

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2016

Could be the part where I simplified construction code.
But I'm sure I tested it both in z-level mode and without, specifically looking for bugs in up/down stair construction.
I might have missed edge cases.

Does this reproduce reliably?

@DangerNoodle

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2016

All tests I have done so far produced this, except when the map tile already has downstairs existing, such as digging downstairs too close to an evac shelter.

@illi-kun illi-kun added the <Bug> label Sep 21, 2016

@DangerNoodle

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2016

Any other possible causes?

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented Nov 3, 2016

This is still happening. The player teleports to the nearest basement when going downstairs.

@DangerNoodle

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2017

That is peculiar. Why does it claim I added the the z-levels label? I rather obviously have no such authority.

anomaly

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2017

This is the second time you've been listed as label setter,

@DangerNoodle

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2017

That was an uploaded crop of a screenshot actually. Still, uncertain what that means.

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2017

@DangerNoodle I was aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.