Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removable Storage Batteries Require 2 Skill #19407

Closed
pisskop opened this issue Nov 22, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@pisskop
Copy link
Contributor

commented Nov 22, 2016

Removable storage batteries shouldnt take any skill to replace and even attempting to mod it to zero difficulty has no effect.

The generic electric car has 2 examples of swappable storage batteries that dont swap

@keyspace

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2016

Relevant commit (from git blame): efdb7a2 - "Migrate vehicle batteries" (to separate JSON file).

data/json/vehicle_parts.json (where the batteries were defined) had duplication.
data/json/vehicleparts/battery.json (definitions here now) uses copy-from+extend, but doesn't add an overriding "difficulty": 0 for storage_battery_removable.

Pretty sure this is unintentional.


EDITs: clean-up.

@keyspace

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2016

Just checked: adding "difficulty": 0 to storage_battery_removable changes installation difficulty, but not removal difficulty. :/


EDIT: ah, it's a legacy part.

EDIT2: battery.json has two parts that are then "extended from" by the rest: battery_car (has requirements) and storage_battery (uses legacy difficulty).

@saneman226

This comment has been minimized.

Copy link

commented Nov 30, 2016

What I am thinking is that there could be a small chance based on your intelligence (and if you have 0 mechanics) that you could be zapped by the removable storage batteries, and when mechanics 1 is achieved, it would return to normal. Perhaps this would make you think twice about removing highly charged batteries. Also there should not be any skill gained by removing or adding removable storage batteries since it is such an easy task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.