Moving diagonally around a dragged vehicle should not bring the player on top of the vehicle

[remyroy]

If you grab a vehicle like a cart and you move diagonally around it, it will bring the player on top of the vehicle. Here are a few examples where . is an empty tile, P is the player, = is the vehicle and ₱ is the player on the vehicle.

If you start from this position (player is down from the vehicle), you have the player dragging the vehicle

...
.=.
.P.

and you move up-left you will end up like

...
₱..
...

The expected behavior is that the player just move around the vehicle and end up like

...
P=.
...

The other diagonal directions have similar behaviors. If you move up-right from the same original position (player is down from the vehicle), you will end up like

...
..₱
...

while the expected end result should be like

...
.=P
...

This issue also has the unintended consequence of adding a message like Moving onto this dirt is slow when performing those diagonal moves. This is most likely due to the fact that the player moves on the vehicle (which is slow) but the vehicle is not already on the tile at that point when displaying the message (empty tile with dirt is the tile in this example).

This has been the behavior in the latest experimental version (0.C-20238-g71a073f).

[CoroNaut]

Why was this made a new issue? I feel like you could've fixed this bug along with the crashes that go along with it all in one. Also, don't forget to turn the vehicle itself to the new direction.

[remyroy]

If you feel like this is a duplicate of an issue, let me know which one and I'll close this one.

[CoroNaut]

The one you fixed recently was caused by this problem in the first place.

[remyroy]

If you are referring to #19769 and #19168 then I would disagree but I might be wrong. Can you share your knowledge with me?

[CoroNaut]

It really isn't that big of a deal, but the way I think of it is that the crash was caused by the diagonal movement in the first place. The first bug was the diagonal movement, and further bugs discovered because of this bug was just stuff that shouldn't have been there in the first place. In other words, fixing the first bug would solve the rest that were caused by it. You really didn't need to fix the crashing portion if you could've fixed the diagonal movement and been done with the whole thing.

[remyroy]

How do you know that the crash was caused by the diagonal issue?

[CoroNaut]

Because you can only receive the crash when stepping onto a vehicle while doing this exact movement. If you can get the crash through other means, then it hasn't shown up yet and I don't think it ever would have because this is the only way it was caused. The other issues popped up solely because of this diagonal movement bug.

[remyroy]

While testing for #19168, I was able to cause the crash without doing any diagonal movements just like it is shown on the screenshot. If you load that save game, you go to that cart, you grab it from the right side, you go right a few tiles and than up a few tiles, that will cause the crash without using any diagonals.

[CoroNaut]

I was thinking more along the lines of: #19676, these two problems are related in that the cart is moved in the wrong way such as in this post. This problem isn't particularly new either, its been happening for quite a while now.

[sethsimon]

This is a duplicate of #18093.

[illi-kun]

Thanks for the note. I've closed referenced issue since it seems thst current issue contains more info.

[kolsurma]

This appears to no longer be applicable.

Can anyone else confirm the bug still exists?

[kevingranade]

It's not, Coolthulu fixed it.