Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json errors no longer being displayed (curses) #20678

Closed
Wad67 opened this issue Mar 26, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@Wad67
Copy link

commented Mar 26, 2017

Forgive me if this is a duplicate issue, or is already known in some way.

To reproduce, write a json mod that is bugged in some way.
Expected behavior: error message pertaining to bugged json file
Actual behavior: game hangs for a moment, then returns to title screen

This may be related to #20649

@codemime

This comment has been minimized.

Copy link
Member

commented Mar 26, 2017

Could you write an example?

@Wad67

This comment has been minimized.

Copy link
Author

commented Mar 26, 2017

Fairly sure this is the bugged piece of code, although I have no way of telling due to aforementioned issue.

[
{
"id": "tank_500ml",
"type": "vehicle_part",
"name": "vehicle tank (500ml)",
"item": "bottle_plastic",
"location": "fuel_source",
"symbol": "O",
"broken_color": "red",
"difficulty": 1,
"durability": 75,
"size": 500,
"damage_modifier": 80,
"breaks_into": [
{ "item": "plastic_chunk", "count": [ 2, 5 ] }
],
"extend": { "flags": [ "FOLDABLE", "TOOL_SCREWDRIVER" ] }
},
]

@codemime

This comment has been minimized.

Copy link
Member

commented Mar 26, 2017

It worked as expected for me (I got the error). What's your OS?

@Wad67

This comment has been minimized.

Copy link
Author

commented Mar 26, 2017

Windows 7 Ultimate x64.

@Wad67

This comment has been minimized.

Copy link
Author

commented Mar 26, 2017

http://imgur.com/a/CD1HR

Compiling with 'debug' target does the same thing.
Can currently only test terminal build, don't have SDL.

Just tried an sdl experimental build (6359) and it shows the error message fine.
The exact same curses build, does not show the error message.

@Wad67 Wad67 changed the title Json errors no longer being displayed Json errors no longer being displayed (curses) Mar 26, 2017

@BorkBorkGoesTheCode

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2017

#20061 and #20107 probably share the same cause.

@pisskop

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2017

They definitely show up in my linux builds, for mods.

@Wad67

This comment has been minimized.

Copy link
Author

commented Mar 27, 2017

Just took the time to test this in linux also, both SDL and CURSES render the debugmsg just fine.

So that narrows the problem down to something related to the windows CURSES build.

@Leland Leland added the OS: Windows label May 8, 2017

@Leland

This comment has been minimized.

Copy link
Contributor

commented May 8, 2017

Duplicate of #20061. Thanks for taking the time to test this out, copying over your notes to the main thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.