New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmines feature torso homing shrapnel #22025

Open
Alkheemist opened this Issue Sep 29, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@Alkheemist

Alkheemist commented Sep 29, 2017

Game version: 0.C-23730-g4b6197d

Operating system: Windows

Tiles or curses: Tiles

Mods active: DDA, Filthy Clothing, Disable NPC Needs, Simplified Nutrition

Expected behavior

Landmines detonating will damage all parts of the body roughly equally, proportional to distance. Damage from landmine explosions appear on the message log.

Actual behavior

Being anywhere within the blast radius of a detonating landmine results in immediately dying from torso damage. Damage to other parts of the body is rare, and no messages are created.

Steps to reproduce the behavior

Place a landmine. While standing about 3 or 4 tiles away from the landmine, lure zombie onto the landmine. (sometimes) die horribly with no clear indication.

My guess is that landmines have shrapnel which is VERY effective, and does more damage than regular survivors have health. If this is the case then the message log should probably indicate that you were hit by shrapnel. As it stands, a landmine will detonate nearby and then you get the "watch the last moments of your life?" prompt. The damage doesn't appear on the message log and you simply see that all your torso health is gone.

nolog
This is the message log of a test character. This particular one survived 5 landmines before dying, indicating that this is most likely shrapnel. But without any messages, I'm not sure if something else is afoot.

@Alkheemist

This comment has been minimized.

Show comment
Hide comment
@Alkheemist

Alkheemist Sep 29, 2017

nolog2
Another image of the message log for a different character. This is the message log seen after typing in your epitaph. I think this is actually a shrapnel related message log bug, since further testing resulted in a character which did get a damage message, although on a limb. Perhaps if a fatal shrapnel blow is dealt it never appears on the log?

Alkheemist commented Sep 29, 2017

nolog2
Another image of the message log for a different character. This is the message log seen after typing in your epitaph. I think this is actually a shrapnel related message log bug, since further testing resulted in a character which did get a damage message, although on a limb. Perhaps if a fatal shrapnel blow is dealt it never appears on the log?

@greenman74

This comment has been minimized.

Show comment
Hide comment
@greenman74

greenman74 Dec 6, 2017

Game version: 0.C-25249-g6b0cc3f

Operating system: Windows 10

Tiles or curses: Tiles

Mods active: DDA, Filthy Clothing, Disable NPC Needs, Simplified Nutrition

I have noticed the same issue, as of version cataclysmdda-0.C-6981. I was had full HP, with the tough trait with 20% extra hit points and my armor in full repair. I wore a bone suit, bone helmet, bone gloves, and bone boots. I also wore a O-yoroi suit on top of that.
landmines

greenman74 commented Dec 6, 2017

Game version: 0.C-25249-g6b0cc3f

Operating system: Windows 10

Tiles or curses: Tiles

Mods active: DDA, Filthy Clothing, Disable NPC Needs, Simplified Nutrition

I have noticed the same issue, as of version cataclysmdda-0.C-6981. I was had full HP, with the tough trait with 20% extra hit points and my armor in full repair. I wore a bone suit, bone helmet, bone gloves, and bone boots. I also wore a O-yoroi suit on top of that.
landmines

@greenman74

This comment has been minimized.

Show comment
Hide comment
@greenman74

greenman74 Dec 6, 2017

Using the debug menu, and walking into unseen buried land mines a few times, it seems clear that the message log with the display of torso damage is off. With a fresh character, using the map editor to walk into land mines, this full HP character took 33 torso damage, yet his torso is almost gone. Other body parts (except for his left arm) have taken worse damage, yet they are at higher health even after being damaged from the buried land mine.
debug

greenman74 commented Dec 6, 2017

Using the debug menu, and walking into unseen buried land mines a few times, it seems clear that the message log with the display of torso damage is off. With a fresh character, using the map editor to walk into land mines, this full HP character took 33 torso damage, yet his torso is almost gone. Other body parts (except for his left arm) have taken worse damage, yet they are at higher health even after being damaged from the buried land mine.
debug

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Dec 22, 2017

Member

Due to phrasing in the messages, we can tell where the damage came from.
Your <bodypart> was hit is from the blast.
You were hit in the <bodypart> is from bomb fragments.

It does look like death from bomb fragments isn't being reported, but I don't have any guesses why it's happening from reading the code.

I'm actually in the middle of overhauling this code, replacing the random samples of fragment paths with a more field-like system where roughly everything in range is hit unless something (i.e. a wall) blocks the path. I'll be dropping the damage some too, but expect fragmentation bombs to continue to be quite deadly at close range.

Member

kevingranade commented Dec 22, 2017

Due to phrasing in the messages, we can tell where the damage came from.
Your <bodypart> was hit is from the blast.
You were hit in the <bodypart> is from bomb fragments.

It does look like death from bomb fragments isn't being reported, but I don't have any guesses why it's happening from reading the code.

I'm actually in the middle of overhauling this code, replacing the random samples of fragment paths with a more field-like system where roughly everything in range is hit unless something (i.e. a wall) blocks the path. I'll be dropping the damage some too, but expect fragmentation bombs to continue to be quite deadly at close range.

@Alkheemist

This comment has been minimized.

Show comment
Hide comment
@Alkheemist

Alkheemist Dec 22, 2017

For path blocking, will you include vehicles? The first time I encountered this bug my character was killed by shrapnel while wearing heavy survivor armour and driving a tank. I feel like shrapnel should not be able to penetrate tank armour, let alone defeat some of the most effective armour in the game outright from it's maximum range.

Alkheemist commented Dec 22, 2017

For path blocking, will you include vehicles? The first time I encountered this bug my character was killed by shrapnel while wearing heavy survivor armour and driving a tank. I feel like shrapnel should not be able to penetrate tank armour, let alone defeat some of the most effective armour in the game outright from it's maximum range.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Dec 23, 2017

Member
Member

kevingranade commented Dec 23, 2017

@Isaacssv552 Isaacssv552 referenced this issue Apr 21, 2018

Closed

[WIP] Vehicle Overhaul Part 1a #23560

18 of 21 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment