New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page outlining how to interact with CI to contributing.md #22073

Open
kevingranade opened this Issue Oct 3, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@kevingranade
Member

kevingranade commented Oct 3, 2017

I just realized we don't have an outline anywhere of how our CI builds work or how to interact with them.

Sketch out a sub-page of the site outlining the features of each and how to determine what went wrong on a failed build.

@Treah

This comment has been minimized.

Show comment
Hide comment
@Treah

Treah Oct 3, 2017

Contributor

This would be welcome as I have had Travis fail on me before for seemingly no reason other then apt-get command.

Contributor

Treah commented Oct 3, 2017

This would be welcome as I have had Travis fail on me before for seemingly no reason other then apt-get command.

@ZhilkinSerg

This comment has been minimized.

Show comment
Hide comment
@ZhilkinSerg

ZhilkinSerg Oct 4, 2017

Contributor

Please explain Codecov too - it is now commenting json-only changes (#22075).

Contributor

ZhilkinSerg commented Oct 4, 2017

Please explain Codecov too - it is now commenting json-only changes (#22075).

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 4, 2017

Member

Yea I just added that and didn't realize it would spam every PR, I'll turn that off.

Member

kevingranade commented Oct 4, 2017

Yea I just added that and didn't realize it would spam every PR, I'll turn that off.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 4, 2017

Member

Tracked the setting down and applied it, well see if that does it.

Member

kevingranade commented Oct 4, 2017

Tracked the setting down and applied it, well see if that does it.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 4, 2017

Member

Looks like we have no reports as of #22081

Member

kevingranade commented Oct 4, 2017

Looks like we have no reports as of #22081

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 4, 2017

Member

Tracked the setting down and applied it, well see if that does it.

Member

kevingranade commented Oct 4, 2017

Tracked the setting down and applied it, well see if that does it.

@ZhilkinSerg

This comment has been minimized.

Show comment
Hide comment
@ZhilkinSerg

ZhilkinSerg Oct 4, 2017

Contributor

Codecov reports changes in CPP files that were unchanged in PR in the report - see example in https://codecov.io/gh/CleverRaven/Cataclysm-DDA/pull/22080/changes

Does it compare source with some invalid base or what?

Contributor

ZhilkinSerg commented Oct 4, 2017

Codecov reports changes in CPP files that were unchanged in PR in the report - see example in https://codecov.io/gh/CleverRaven/Cataclysm-DDA/pull/22080/changes

Does it compare source with some invalid base or what?

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 5, 2017

Member

You're seeing test coverage changes because the tests have RNG in them.

Member

kevingranade commented Oct 5, 2017

You're seeing test coverage changes because the tests have RNG in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment