New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New loading screens prevent json errors from showing in Curses version #22086

Closed
i2amroy opened this Issue Oct 5, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@i2amroy
Member

i2amroy commented Oct 5, 2017

What happens:
Under the new loading screen JSON errors still get flagged (and require one button press to move past), but the new loading screen makes them never actually be visible.

What should happen:
JSON errors are displayed as normal.

How to replicate:

  1. Change the warmth value of any item in armor.json to 0 (the default value, which throws an error).
  2. Load up a world. The loading will hang at the loading "dda" step because it's secretly waiting for you to acknowledge the (invisible) json error.
  3. Press spacebar. The screen should then flash black for an instant and then loading should continue and work fine.
@Coolthulhu

This comment has been minimized.

Show comment
Hide comment
@Coolthulhu

Coolthulhu Oct 5, 2017

Contributor

Tiles/console? Software rendering on/off?

Contributor

Coolthulhu commented Oct 5, 2017

Tiles/console? Software rendering on/off?

@ZhilkinSerg

This comment has been minimized.

Show comment
Hide comment
@ZhilkinSerg

ZhilkinSerg Oct 5, 2017

Contributor

I believe the issue affects anyerrors, not only JSON-related.

I've just caught same issue on Windows 64 Console build 6832 when loading was stuck on Overmap.

default

instead of showing this error (like it was in prior builds):

default

Contributor

ZhilkinSerg commented Oct 5, 2017

I believe the issue affects anyerrors, not only JSON-related.

I've just caught same issue on Windows 64 Console build 6832 when loading was stuck on Overmap.

default

instead of showing this error (like it was in prior builds):

default

@i2amroy i2amroy changed the title from New loading screens prevent json errors from showing to New loading screens prevent json errors from showing in Curses version Oct 5, 2017

@i2amroy

This comment has been minimized.

Show comment
Hide comment
@i2amroy

i2amroy Oct 5, 2017

Member

Tiles/console? Software rendering on/off?

Double checking this it only applies to the curses version, the errors show just fine in tiles mode. Haven't checked software rendering on/off, but I had mine set to off for both of those tests.

Member

i2amroy commented Oct 5, 2017

Tiles/console? Software rendering on/off?

Double checking this it only applies to the curses version, the errors show just fine in tiles mode. Haven't checked software rendering on/off, but I had mine set to off for both of those tests.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Jan 3, 2018

Member

Ideally we just throw some perf improvements at json loading and nuke the loading screen.

Member

kevingranade commented Jan 3, 2018

Ideally we just throw some perf improvements at json loading and nuke the loading screen.

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik May 21, 2018

Member

Tested on latest experimental curses version - no longer an issue.

default

Member

Night-Pryanik commented May 21, 2018

Tested on latest experimental curses version - no longer an issue.

default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment