New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop providing the windows "curses" builds #22087

Open
Coolthulhu opened this Issue Oct 5, 2017 · 6 comments

Comments

Projects
None yet
7 participants
@Coolthulhu
Contributor

Coolthulhu commented Oct 5, 2017

Windows pseudo-curses builds have very low performance and have their own problems that don't happen in tiles builds. They actually set some of the tiles flags, because they aren't actually curses builds.
Proper tiles builds have up to 10 times faster drawing than pseudo-curses, as they cache drawn surfaces. Pseudo-curses achieve the same effect with Windows string drawing functions, which are pretty unsuited to drawing one character at a time.

The code for them could remain for testing, as it is quite useful not to have to supply whole SDL just to compile the game in codeblocks, but those builds are low quality and should not be provided to end users who want to play the game rather than just testing things.

This only affects windows pseudo-curses builds. *nix ones are fine.

@AMurkin

This comment has been minimized.

Show comment
Hide comment
@AMurkin

AMurkin Oct 5, 2017

Contributor

Note: but now only curses compiles.
Please see my comment in #21867.

Contributor

AMurkin commented Oct 5, 2017

Note: but now only curses compiles.
Please see my comment in #21867.

@i2amroy

This comment has been minimized.

Show comment
Hide comment
@i2amroy

i2amroy Oct 5, 2017

Member

Note: but now only curses compiles.

Strange, I'm literally running a windows 64 SDL build for my development stuff right now (Seeing as how the curses has the problem displaying errors at the moment) and it's compiling just fine.

Member

i2amroy commented Oct 5, 2017

Note: but now only curses compiles.

Strange, I'm literally running a windows 64 SDL build for my development stuff right now (Seeing as how the curses has the problem displaying errors at the moment) and it's compiling just fine.

@Coolthulhu

This comment has been minimized.

Show comment
Hide comment
@Coolthulhu

Coolthulhu Oct 5, 2017

Contributor

It's related to SOUND=1, I'll get on it after I finish this merge run. Either way, it's unrelated to the issue here.

Contributor

Coolthulhu commented Oct 5, 2017

It's related to SOUND=1, I'll get on it after I finish this merge run. Either way, it's unrelated to the issue here.

@Leland Leland added the OS: Windows label Oct 6, 2017

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 6, 2017

Member

The code for them could remain for testing,

If you're not proposing we get rid of the code and build support, what are you proposing we get rid of?
My best guess is removing links to it from cataclysmdda.org and narc.ro, and perhaps make an announcement somewhere.

Member

kevingranade commented Oct 6, 2017

The code for them could remain for testing,

If you're not proposing we get rid of the code and build support, what are you proposing we get rid of?
My best guess is removing links to it from cataclysmdda.org and narc.ro, and perhaps make an announcement somewhere.

@CoroNaut

This comment has been minimized.

Show comment
Hide comment
@CoroNaut

CoroNaut Oct 8, 2017

Could you make a tileset that makes the game look like curses?

CoroNaut commented Oct 8, 2017

Could you make a tileset that makes the game look like curses?

@Coolthulhu

This comment has been minimized.

Show comment
Hide comment
@Coolthulhu

Coolthulhu Oct 9, 2017

Contributor

If you're not proposing we get rid of the code and build support, what are you proposing we get rid of?

Ready builds for end users.

My best guess is removing links to it from cataclysmdda.org and narc.ro, and perhaps make an announcement somewhere.

Yeah, something like this.

Could you make a tileset that makes the game look like curses?

Already available. Turn off tileset in options and you get something that looks like ASCII build, but with faster rendering and option to turn on minimap. And sound support, if you want that.

Contributor

Coolthulhu commented Oct 9, 2017

If you're not proposing we get rid of the code and build support, what are you proposing we get rid of?

Ready builds for end users.

My best guess is removing links to it from cataclysmdda.org and narc.ro, and perhaps make an announcement somewhere.

Yeah, something like this.

Could you make a tileset that makes the game look like curses?

Already available. Turn off tileset in options and you get something that looks like ASCII build, but with faster rendering and option to turn on minimap. And sound support, if you want that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment