Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
How to help with Astyle #22093
I would like to do more to help this game develop as I really love playing it. While I'm learning the ins and outs of how the code functions, I figured I could start by helping with the Astyle stuff so here are my questions.
What needs to get done?
I wish I could help with the translation stuff but I don't know another (spoken :P) language. I would love to be able to work on the little fixes so people like @codemime and @Night-Pryanik can focus on the bigger picture things. I know C++ fairly well so I can make fixes to the source code as well as fixes to the JSON files.
I'd hold off on json styling for the moment, I'm just about to swap out the tool we use to do that with #21612, and it will work slightly differently after that lands.
For c++ styling, we use the astyle tool, and have put some wrappers around it in Makefile.
Generally though, you want to restyle a manageable chunk of code, read the diff to check for obvious errors, build the game (with RELEASE=1) and run it to again check for fairly obvious errors, remove any fully-styled files from the astyle blacklist file, then make a pull request with your changes.