New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird road mapgen #22113

Closed
Night-Pryanik opened this Issue Oct 9, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@Night-Pryanik
Member

Night-Pryanik commented Oct 9, 2017

default

@Night-Pryanik Night-Pryanik added the Mapgen label Oct 9, 2017

@ZhilkinSerg

This comment has been minimized.

Show comment
Hide comment
@ZhilkinSerg

ZhilkinSerg Oct 9, 2017

Contributor

I believe Necropolis overmap special was put over existing map tiles and overritten the road.

default

Probably need some road polishing after placing specials with roads or maybe tune connection point settings?

Contributor

ZhilkinSerg commented Oct 9, 2017

I believe Necropolis overmap special was put over existing map tiles and overritten the road.

default

Probably need some road polishing after placing specials with roads or maybe tune connection point settings?

@vache

This comment has been minimized.

Show comment
Hide comment
@vache

vache Oct 9, 2017

Contributor

The mapgen roads don't recognize the roads that are a part of the special as "roads", so they don't know they need to connect to them.

Contributor

vache commented Oct 9, 2017

The mapgen roads don't recognize the roads that are a part of the special as "roads", so they don't know they need to connect to them.

@ZhilkinSerg

This comment has been minimized.

Show comment
Hide comment
@ZhilkinSerg

ZhilkinSerg Oct 9, 2017

Contributor

The mapgen roads don't recognize the roads that are a part of the special as "roads", so they don't know they need to connect to them.

Is it? Ranch and necropolis tiles are defined as road location: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/overmap_locations.json#L57-L67

Contributor

ZhilkinSerg commented Oct 9, 2017

The mapgen roads don't recognize the roads that are a part of the special as "roads", so they don't know they need to connect to them.

Is it? Ranch and necropolis tiles are defined as road location: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/overmap_locations.json#L57-L67

@vache

This comment has been minimized.

Show comment
Hide comment
@vache

vache Oct 9, 2017

Contributor

I think that is only used for placing overmap specials, not for the road connecting.

Contributor

vache commented Oct 9, 2017

I think that is only used for placing overmap specials, not for the road connecting.

@Leland

This comment has been minimized.

Show comment
Hide comment
@Leland

Leland Feb 19, 2018

Contributor

Since this is a one-off incident it'll be tough to replicate. Closing.

Have a feeling it's a dupe of #22358, which was fixed in #22723.

Contributor

Leland commented Feb 19, 2018

Since this is a one-off incident it'll be tough to replicate. Closing.

Have a feeling it's a dupe of #22358, which was fixed in #22723.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment