New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See through all artifact allows me to see rot time of food in crafting menu? #22417

Closed
atealein opened this Issue Nov 13, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@atealein

atealein commented Nov 13, 2017

Game version:
0.C-24831-g6a32f4f
Operating system:
OSX
Tiles or curses:
curses
Mods active:
DDA, Disable NPC needs, folding parts, vehicle additions, tanks and other vehicles, disable religious texts, no antique firearms, stats thru skills and food preservation through ionizing radiation

I found an artifact that has a passive "See through everything" effect. When I am in the crafting menu it lists all sort of additional (hidden?) values for food and other recipes.

screen shot 2017-11-13 at 13 23 16

@Soyweiser

This comment has been minimized.

Show comment
Hide comment
@Soyweiser

Soyweiser Nov 13, 2017

Contributor

It probably lets you see a lot more. As this artifact is sort of the debug artifact now. (I wonder, should we change this? Aka, make a normal 'clairvoyance' artifact effect and a debug one.

Contributor

Soyweiser commented Nov 13, 2017

It probably lets you see a lot more. As this artifact is sort of the debug artifact now. (I wonder, should we change this? Aka, make a normal 'clairvoyance' artifact effect and a debug one.

@atealein

This comment has been minimized.

Show comment
Hide comment
@atealein

atealein Nov 13, 2017

This is not a debug artifact, but an artifact looted in a temple and it has all sorts of other activated and wielded effects. The effects might be the same as the clairvoyance debug artifact and that could be where the glitch comes from. Still, I am not sure why would the see-through-all allow you to see very selectively few hidden variables, seems more like an oversight (pun intended :D ).

atealein commented Nov 13, 2017

This is not a debug artifact, but an artifact looted in a temple and it has all sorts of other activated and wielded effects. The effects might be the same as the clairvoyance debug artifact and that could be where the glitch comes from. Still, I am not sure why would the see-through-all allow you to see very selectively few hidden variables, seems more like an oversight (pun intended :D ).

@Soyweiser

This comment has been minimized.

Show comment
Hide comment
@Soyweiser

Soyweiser Nov 13, 2017

Contributor

Yes, I know, but they probably use the same effect. As in the looted artifact uses the same code as the debug one, which causes the problem. The question is, was this behaviour intentional? Or was it simply something nobody ever thought about because well, people looting temples are rare, and this effect is iirc even rarer. And the rarest of all is people supplying proper bug reports ;). (and of course all three, is rarer still (thanks!)).

Edit: sorry, I didn't see your edit (the browser tab did show your initial comment, but not the edit. And yes it probably is an oversight, if only we had the ... clairvoyance to ... (I'll let myself out))

Contributor

Soyweiser commented Nov 13, 2017

Yes, I know, but they probably use the same effect. As in the looted artifact uses the same code as the debug one, which causes the problem. The question is, was this behaviour intentional? Or was it simply something nobody ever thought about because well, people looting temples are rare, and this effect is iirc even rarer. And the rarest of all is people supplying proper bug reports ;). (and of course all three, is rarer still (thanks!)).

Edit: sorry, I didn't see your edit (the browser tab did show your initial comment, but not the edit. And yes it probably is an oversight, if only we had the ... clairvoyance to ... (I'll let myself out))

@atealein

This comment has been minimized.

Show comment
Hide comment
@atealein

atealein Nov 13, 2017

I believe there was a recent change into the debug artifact actually, can't sure of the PR that made the change, but previously the clairvoyance artifacts spawned by the debug menu had a very specific item id and text. Now they look as any other artifact, except they have only one specific effect on them. And because of that the effect which before might have been a bit different, is the exact same as in the proper artifacts.

atealein commented Nov 13, 2017

I believe there was a recent change into the debug artifact actually, can't sure of the PR that made the change, but previously the clairvoyance artifacts spawned by the debug menu had a very specific item id and text. Now they look as any other artifact, except they have only one specific effect on them. And because of that the effect which before might have been a bit different, is the exact same as in the proper artifacts.

@Leland

This comment has been minimized.

Show comment
Hide comment
@Leland

Leland Nov 13, 2017

Contributor

Perhaps fallout from #22273, which is the most recent PR to affect artifacts.

Contributor

Leland commented Nov 13, 2017

Perhaps fallout from #22273, which is the most recent PR to affect artifacts.

@Soyweiser

This comment has been minimized.

Show comment
Hide comment
@Soyweiser

Soyweiser Nov 13, 2017

Contributor

That could very well be atealein, I myself never got a temple artifact. So you are the more experienced on that.

Contributor

Soyweiser commented Nov 13, 2017

That could very well be atealein, I myself never got a temple artifact. So you are the more experienced on that.

@atealein

This comment has been minimized.

Show comment
Hide comment
@atealein

atealein Nov 13, 2017

I think this type of effect can spawn in any artifact, i just meant to say it that it wasn't obtained through the debug menu, but found in the world.

atealein commented Nov 13, 2017

I think this type of effect can spawn in any artifact, i just meant to say it that it wasn't obtained through the debug menu, but found in the world.

@Soyweiser

This comment has been minimized.

Show comment
Hide comment
@Soyweiser

Soyweiser Nov 13, 2017

Contributor

Ow yes, but if you think that you have seen non debug clairvoyance artifacts in the past, and this one you found has debug clairvoyance characteristics that is unexpected. If the debug artifacts have also changed unexpected, that gives a good lead to what the problem might be. But it was clear you found the artifact, and didn't debug it.

Contributor

Soyweiser commented Nov 13, 2017

Ow yes, but if you think that you have seen non debug clairvoyance artifacts in the past, and this one you found has debug clairvoyance characteristics that is unexpected. If the debug artifacts have also changed unexpected, that gives a good lead to what the problem might be. But it was clear you found the artifact, and didn't debug it.

@atealein

This comment has been minimized.

Show comment
Hide comment
@atealein

atealein Nov 13, 2017

I've had experience with debug artifacts before, mostly because i kept spawning them in typos :D Recently I decided to clear them from my artifacts.gsav and noticed that the old entries are no longer found (as item id) anywhere in the save, but have been replaced by different type of cube artifacts with same effect [11] if i recall correctly, but those artifacts now had proper item id :

Here is example how the old debug artifact looked like:

{"type":"artifact_tool","id":"clairvoyance_plus_rod","name":"clairvoyance rod","description":"Item to test aep_clairvoyance_plus flag. If this spawns randomly, then it's a bug.","sym":"v","color":512,"price":5000,"materials":["steel"],"volume":3,"weight":150,"melee_dam":1,"melee_cut":0,"m_to_hit":-1,"item_flags":[],"techniques":[],"ammo":"NULL","max_charges":0,"def_charges":0,"charges_per_use":0,"turns_per_charge":0,"revert_to":"null","charge_type":0,"effects_wielded":[38],"effects_activated":[],"effects_carried":[]}

new ones look like these:

{"type":"artifact_tool","id":"artifact_3450","name":"Cube of Fungal Graves","description":"The architect's cube.","sym":"*","color":2097408,"price":0,"materials":["steel"],"volume":2,"weight":951,"melee_dam":16,"melee_cut":0,"m_to_hit":-2,"item_flags":[],"techniques":[],"ammo":"NULL","max_charges":0,"def_charges":0,"charges_per_use":1,"turns_per_charge":0,"revert_to":"null","charge_type":0,"effects_wielded":[],"effects_activated":[],"effects_carried":[11]}


The artifact in question i found looks like this:

{"type":"artifact_tool","id":"artifact_3455","name":"Dagger of Shadowy Justice","description":"This is the Dagger of Shadowy Justice.\nIt is the only one of its kind.\nIt may have unknown powers; try activating them.","sym":";","color":2098176,"price":0,"materials":
["steel"],"volume":1,"weight":161,"melee_dam":0,"melee_cut":0,"m_to_hit":0,"item_flags":["SHEATH_KNIFE"],"techniques":[],"ammo":"NULL","max_charges":9,"def_charges":9,"charges_per_use":1,"turns_per_charge":0,"revert_to":"null","charge_type":4,"effects_wielded":[15,24,38],"effects_activated":[14,4,25,27],"effects_carried":[11,20]}

so the "effect" [11] is definitely the same in the debug artifacts and in the normal game artifacts. I have no idea if it was like that before the changes, since I didn't have artifacts at that time.

atealein commented Nov 13, 2017

I've had experience with debug artifacts before, mostly because i kept spawning them in typos :D Recently I decided to clear them from my artifacts.gsav and noticed that the old entries are no longer found (as item id) anywhere in the save, but have been replaced by different type of cube artifacts with same effect [11] if i recall correctly, but those artifacts now had proper item id :

Here is example how the old debug artifact looked like:

{"type":"artifact_tool","id":"clairvoyance_plus_rod","name":"clairvoyance rod","description":"Item to test aep_clairvoyance_plus flag. If this spawns randomly, then it's a bug.","sym":"v","color":512,"price":5000,"materials":["steel"],"volume":3,"weight":150,"melee_dam":1,"melee_cut":0,"m_to_hit":-1,"item_flags":[],"techniques":[],"ammo":"NULL","max_charges":0,"def_charges":0,"charges_per_use":0,"turns_per_charge":0,"revert_to":"null","charge_type":0,"effects_wielded":[38],"effects_activated":[],"effects_carried":[]}

new ones look like these:

{"type":"artifact_tool","id":"artifact_3450","name":"Cube of Fungal Graves","description":"The architect's cube.","sym":"*","color":2097408,"price":0,"materials":["steel"],"volume":2,"weight":951,"melee_dam":16,"melee_cut":0,"m_to_hit":-2,"item_flags":[],"techniques":[],"ammo":"NULL","max_charges":0,"def_charges":0,"charges_per_use":1,"turns_per_charge":0,"revert_to":"null","charge_type":0,"effects_wielded":[],"effects_activated":[],"effects_carried":[11]}


The artifact in question i found looks like this:

{"type":"artifact_tool","id":"artifact_3455","name":"Dagger of Shadowy Justice","description":"This is the Dagger of Shadowy Justice.\nIt is the only one of its kind.\nIt may have unknown powers; try activating them.","sym":";","color":2098176,"price":0,"materials":
["steel"],"volume":1,"weight":161,"melee_dam":0,"melee_cut":0,"m_to_hit":0,"item_flags":["SHEATH_KNIFE"],"techniques":[],"ammo":"NULL","max_charges":9,"def_charges":9,"charges_per_use":1,"turns_per_charge":0,"revert_to":"null","charge_type":4,"effects_wielded":[15,24,38],"effects_activated":[14,4,25,27],"effects_carried":[11,20]}

so the "effect" [11] is definitely the same in the debug artifacts and in the normal game artifacts. I have no idea if it was like that before the changes, since I didn't have artifacts at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment