New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow [r]eloading of liquid containers. #22463

Closed
ShadowDragon8685 opened this Issue Nov 21, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@ShadowDragon8685

ShadowDragon8685 commented Nov 21, 2017

Game version: 0.C-6933

Operating system: Win 7 x64

It would be (very very) nice if you could [r]eload liquid containers (e.g. canteen, bottle, etc,) from the reload menu/from Activating the item and pressing [r], searching your character and the tiles around your character for liquids which can be put in.

This way the player could [r]eload my canteen from all the bottles in their lockers quite simply, rather than having to pick up the bottles and [U]nload them into the canteen.

@Xelat84

This comment has been minimized.

Show comment
Hide comment
@Xelat84

Xelat84 Nov 21, 2017

Contributor

rather than having to pick up the bottles and [U]nload them into the canteen.

Actually you at least don't have to pick them up, it's enough to stay close to them. Unloading works with items laying in adjacent tiles.

Contributor

Xelat84 commented Nov 21, 2017

rather than having to pick up the bottles and [U]nload them into the canteen.

Actually you at least don't have to pick them up, it's enough to stay close to them. Unloading works with items laying in adjacent tiles.

@ShadowDragon8685

This comment has been minimized.

Show comment
Hide comment
@ShadowDragon8685

ShadowDragon8685 Nov 21, 2017

That's... Helpful. At least it lets me use my giant water barrel now. But it still seems that you should be able to reload a liquid-container.

ShadowDragon8685 commented Nov 21, 2017

That's... Helpful. At least it lets me use my giant water barrel now. But it still seems that you should be able to reload a liquid-container.

@Broken-Admin

This comment has been minimized.

Show comment
Hide comment
@Broken-Admin

Broken-Admin Nov 23, 2017

Contributor

If we did this it would allow getting spilled liquids up, which shouldn't be possible.

Contributor

Broken-Admin commented Nov 23, 2017

If we did this it would allow getting spilled liquids up, which shouldn't be possible.

@sxmichaels

This comment has been minimized.

Show comment
Hide comment
@sxmichaels

sxmichaels Nov 28, 2017

Contributor

@Broken-Admin Not necessarily, especially if you tweak the already-existing magazine reload functionality to do it! I thought this was a great QoL fix so I had a go at implementing it — check out #22507. (I originally thought it would be a simple addition… little did I know how deeply the reload function's tendrils extend into other parts of the code, ha ha. Didn't need to add much code, but it took quite a while to figure out where to put it!)

Contributor

sxmichaels commented Nov 28, 2017

@Broken-Admin Not necessarily, especially if you tweak the already-existing magazine reload functionality to do it! I thought this was a great QoL fix so I had a go at implementing it — check out #22507. (I originally thought it would be a simple addition… little did I know how deeply the reload function's tendrils extend into other parts of the code, ha ha. Didn't need to add much code, but it took quite a while to figure out where to put it!)

@boydkr

This comment has been minimized.

Show comment
Hide comment
@boydkr

boydkr Feb 8, 2018

Contributor

It would appear t his issue can be closed since #22507 is merged

Contributor

boydkr commented Feb 8, 2018

It would appear t his issue can be closed since #22507 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment