New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames used in Start Vehicle Construction Change to Default Quality rather than Actual Quality #22653

Open
DracoGriffin opened this Issue Dec 21, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@DracoGriffin
Member

DracoGriffin commented Dec 21, 2017

Game version: Experimental 7004

Operating system: Windows 7 64-bit

Tiles or curses: Tiles

Mods active: Default (Dark Days Ahead, Filthy Clothing, Disable NPC Needs, Simplified Nutrition)

Expected behavior

Initial vehicle frames utilized in "Start Vehicle Construction" construction option should remain reinforced, even when later removed.
edit: Initial vehicle frames utilized in "Start Vehicle Construction" construction option should remain the quality they are when creating a new vehicle, even when later removed.

Actual behavior

Initial vehicle frames utilized in "Start Vehicle Construction" construction option lose reinforced status, and even when later removed, do not regain the reinforced status (instead produces a non-reinforced frame). Current "work-around" is to use a non-reinforced frame initially, examine vehicle, and install a reinforced frame in an empty adjacent tile.
edit: Initial vehicle frames utilized in "Start Vehicle Construction" construction option are changed to default normal quality, rather than the inherent quality of the frame being used. (If a damaged frame is used in the initial construction of a vehicle, it will "magically" be repaired, and when later removed, it will now be a normal quality frame, rather than being damaged, essentially creating a loophole to repairing damaged frames freely and quickly.)

Steps to reproduce the behavior

Debug wish a type of frame, some type of welder, reinforce frame with appropriate materials, open Construction menu and "Start Vehicle Construction" using the aforementioned reinforced frame, and examine the vehicle. Additionally, remove the frame from vehicle with appropriate tools and item produced will be a non-reinforced version of the item.
edit: Damage a frame or remove one from a damaged pre-existing vehicle, open the Construction menu and "Start Vehicle Construction" with damaged frame and it will show the new vehicle with a repaired frame, rather than the damaged state it was acquired. If it later removed, it will remain repaired.

reinforcedsteelframe
lostreinforcedstatus
proofreinforcedframeswork

@Isaacssv552

This comment has been minimized.

Show comment
Hide comment
@Isaacssv552

Isaacssv552 Dec 22, 2017

Contributor

This is probably an issue with the C++ for "done_vehicle" and the "vehicle_start" flag.

Contributor

Isaacssv552 commented Dec 22, 2017

This is probably an issue with the C++ for "done_vehicle" and the "vehicle_start" flag.

@DracoGriffin

This comment has been minimized.

Show comment
Hide comment
@DracoGriffin

DracoGriffin Dec 24, 2017

Member

You can reinforce any vehicle part and install it and it will be the reinforced quality (aka the dark green).

Additionally to this issue, installing damaged frames also results in a fixed/normal frame (so installing a |. quality frame as the initial vehicle construction frame will result with the bright green quality, instead of the quality/color it should be).

Member

DracoGriffin commented Dec 24, 2017

You can reinforce any vehicle part and install it and it will be the reinforced quality (aka the dark green).

Additionally to this issue, installing damaged frames also results in a fixed/normal frame (so installing a |. quality frame as the initial vehicle construction frame will result with the bright green quality, instead of the quality/color it should be).

@DracoGriffin DracoGriffin changed the title from Frames used in Start Vehicle Construction Lose Reinforced Status to Frames used in Start Vehicle Construction Change to Default Quality rather than Actual Quality Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment