New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassembling reversive-craft items made with sewing kits should be possible only with cutting tools #22707

Closed
Night-Pryanik opened this Issue Jan 7, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@Night-Pryanik
Member

Night-Pryanik commented Jan 7, 2018

Game version: 0.C-7046

Operating system: Windows XP SP3 x86

Tiles or curses: curses

Mods active: default only

Expected behavior

One should be able to disassemble quiver only with some cutting tool, and tool with sewing of 1 or more isn't required
OR
quiver shouldn't appear at the Disassemble item menu, and the only way to actually disassemble it is to cut it.

Actual behavior

One can't disassemble quiver without tool with sewing of 1 or more.

Steps to reproduce the behavior

Try to disassemble quiver without some sewing tool.

This issue was already stated in the second point of #13978, but although that issue was closed, the problem remains, and I decided to revive it.
And while there is a code in requirements.cpp

if( type == "sewing_kit" ||
type == "mold_plastic" ) {
new_qualities.emplace_back( quality_id( "CUT" ), 1, 1 );
replaced = true;
break;
}

it seems that it doesn't work the way it should.

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Jan 13, 2018

Member

Similar issue, but with disassembling metal items requiring hacksaw and welding goggles: #16783.

Member

Night-Pryanik commented Jan 13, 2018

Similar issue, but with disassembling metal items requiring hacksaw and welding goggles: #16783.

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Mar 2, 2018

Member

Closed by #22774.

Member

Night-Pryanik commented Mar 2, 2018

Closed by #22774.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment