Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch cleaning of clothes #22776

Closed
DanielPBak opened this issue Jan 16, 2018 · 14 comments

Comments

Projects
None yet
5 participants
@DanielPBak
Copy link
Contributor

commented Jan 16, 2018

It's extremely annoying cleaning a large amount of clothing, requiring a large number of key presses to clean a single item. This is difficult if you are cleaning a large number of clothing, or 10 kevlar patches or something. There should be a way to do this more efficiently.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Jan 16, 2018

#21650 is meant to address this issue..

@DanielPBak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2018

I don't think it addresses it fully... even with a washboard, you shouldn't need to do all of these key pressed and spend all this (real life) time.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Jan 16, 2018

Well, how do you see it working then?

@DanielPBak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2018

I think, rather than selecting a single item and washing it, you should be able to tag multiple items (similarly to how one grabs items off the ground) and wash them in bulk at once. I'd be willing to implement this if the PR would be accepted.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Jan 16, 2018

Go ahead and make a PR.

@Nhatorama

This comment has been minimized.

Copy link

commented Jan 25, 2018

When I played on Windows, I used AutoHotKey for any repetitive things I wanted to do, like:

  • tilling(with a hoe)/planting/harvesting vast tracts of land
  • unloading containers (usually pickled food)
  • making clean water (didn't have water_purifier/FOODCO yet)
  • giving follow/guard commands to my NPC followers.
  • prior to the nerf, throwing training by throwing bones at the max range

Now that I'm on Linux I use AutoKey.

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Feb 8, 2018

@DanielPBak any luck on your plans?

@DanielPBak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2018

I haven't had much time and the cleaning code is more complex than I thought. But I'm still intending on doing it. Would you mind if I asked you some questions about it, since you seem like you know it pretty well?

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Feb 10, 2018

Of course, ask freely!

@DanielPBak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2018

What's the best way to reach you? On here?

@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

Here, yes. Someone else might be willing to help too.

@DanielPBak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2018

I have to admit that I'm having a lot of difficulty with this.

So, I basically want to replace the "wash what?" menu, where a single item is selected, with a menu where multiple items are selected, and the required amount of time, water and soap is displayed in the top right corner, out of their maximums.

I don't know how to get started on this. I was thinking I'd be able to use the "pick up" menu as a template, but I don't know how to get started on that either. I don't even know where the "pick up" menu is generated in the code. I can see ACTION_PICKUP in many places, but after a few hours of searching I can't see where in the process the menu is generated.

I need INV_FOR_FLAG, except it queries for multiple items rather than just one. Does such a function exist? Can I use INV_FOR_FLAG to achieve this? How does INV_FOR_FLAG generate UI? From what I can see, it just searches for items... when is the UI drawn in all of this? Is there some way to use INVENTORY_MULTISELECTOR for this purpose?

I'm sorry that this is such a general question, but what should I be doing or looking into? Is there a function I should know that generates a multiple-tag window, as opposed to a single one? What should my general plan here be?

Is there any documentation that explains how the UI is drawn?

Suffice it to say that I didn't expect displaying a menu of all filthy items to be so complicated!

@RogueYun

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2018

I had an idea, but I am not sure of the difficulty to implement. Perhaps it may be an easier alternative to your idea.

A "Wash Basin" something like a brazier in simple structures that can be placed/taken down/replaced.
(Made from a washboard + some large container/bucket?)

  • Would have a limited volume but could hold several large clothing items (Say 20-40 liters?).
  • Would need a large amount of water nearby.
  • Stuff full of filthy laundry.
  • One would "apply" soap or detergent to use. (Alternatively maybe a fire nearby so the water/clothes could be sterilized)
  • All items in the basin would be washed over an extended period of time.
  • The PC would complain about having raisin fingers.
@Night-Pryanik

This comment has been minimized.

Copy link
Member

commented May 21, 2018

Closed by #23588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.