Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evac shelter computer: “Contact Us” menu looks like the game is freezing, and other issues #23396

Closed
Wuzzy2 opened this issue Apr 6, 2018 · 7 comments

Comments

8 participants
@Wuzzy2
Copy link
Contributor

commented Apr 6, 2018

Game version:
ae5bdc0

Operating system:
GNU/Linux

Tiles or curses:
curses

Mods active:
Just the default stuff

Summary

This is about the “Contact Us” menu in the evac shelter computer.

While the game tries to trace the way to the refugee center, it freezes, sometimes very long. There is NOT indication on the screen what is happening. I have Ctrl+C-ed out of the game multiple times because I was convinced the game froze :-(

There are other issues:

  • The final sentence in the displayed is not completed, the address name is not written. The name of the city should be included, don't you think?
  • The “Reach Refugee Center” mission does not have a mission text.
  • The search for a road can sometimes take absurdly long. I hear my CPU spin up! Can you try to make it faster?

Suggestions to fix this:

  • When the map starts loading, show in the computer console “Downloading map data, please wait …” or something similar. If it is done, write “Done!”.
  • Come up with a fake facilty name which includes the city name to finish the final sentence, also display the coordinates

Steps to reproduce the behaviour

Start a default game, go to evac shelter computer, use contact option.

Pretend you didn't see this feature before. Get confused why none of the controls work and Ctrl+C in your pretend desparation. xD

@Wuzzy2 Wuzzy2 changed the title Evac shelter, “Contact Us” menu looks like freezing and other issues Evac shelter computer: “Contact Us” menu looks like the game is freezing, and other issues Apr 6, 2018

@codemime

This comment has been minimized.

Copy link
Member

commented Apr 8, 2018

The search for a road can sometimes take absurdly long. I hear my CPU spin up! Can you try to make it faster?

This is not solely searching for a road that takes so absurdly long. Primarily, the delay happens because of generating an overmap containing the said road. The refugee center can be several overmaps away. Which means several overmaps have to be generated before the resulting path could be acquired. This takes time. I don't see a clear way of dramatically reducing its amount, except for steadily placing the refugee center nearer.

Suggestions to fix this:

I like both. Also, the mission text that you've mentioned would be nice to have.

@Leland Leland added the Mapgen label Apr 8, 2018

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2018

The bigger problem than the long load time is the lack of any UI response during this time. If you can't lower the load time, fix the UI first.

@FulcrumA

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2018

Thanks to @ralreegorganon and his changes to the refugee center, it's being consistently placed a bit nearer (though depending on one's luck and world setting - often still requiring a considerable, even if not truly epic ride to get there which is IMHO just right) thus usually putting far lesser strain on initial "Contact us" calculation and providing a direction to said center far more reliably.

While not a direct fix, it makes the issue more of a potential problem rather than a truly existing one now, though suggested messages and changes to the name seem like a good, little improvement.

@kevingranade kevingranade moved this from Hard Issues to Confirm Fix in 0.D Release Sep 26, 2018

@Inglonias

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2018

I'm not noticing nearly as much freezing now, and I didn't even notice the evac center placements were relaxed.

I don't know if that counts as a real fix for the issue, but it certainly does mitigate it. Is that enough to call this "closed" for 0.D? I dunno. It's not up to me. But this issue has been mitigated.

@kevingranade

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

If we don't see an obvious fix, that will probably be sufficient.

@mlangsdorf

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

@Wuzzy2 can we close this issue?

@Wuzzy2

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2018

This seems to work fine now. The refugee center is now found almost instantly, so this is not an issue anymore. Yes, I think this issue can be closed. 👍


PS: Will someone please notify me when C:DDA is ready to be translated (string freeze)? I have decided to refuse to use Transifex from now on (proprietary JavaScript) so I need to use something else. Contact me with an @-mention or in IRC (Wuzzy in irc.freenode.net) or XMPP (Wuzzy2@jabber.ccc.de) or with an e-mail (Wuzzy2@mail.ru) when the string freeze happens. Sorry to bring this up here, but the forums are completely broken, so I stopped using those (stupid Discourse!) and I don't know how to contact you otherwise.

@mlangsdorf mlangsdorf closed this Oct 15, 2018

0.D Release automation moved this from Confirm Fix to Closed Issues Oct 15, 2018

Mapgen and overmapgen improvements automation moved this from To do to Done Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.