Unloading magazines (especially belts) can lead to player move starvation for a long time.

[kevingranade]

Expected behavior

Unloading an ammunition belt can be interrupted by '.' or safe mode.

Actual behavior

Unloading an ammunition belt is uninterruptable and can allow a monster to kill you while performing it.

Steps to reproduce the behavior

Stand near the corner of a building.
Spawn a full (hundreds of rounds) ammunition belt.
Spwn a hostile monster nearby.
Run around the corner of the building, breaking sight with the monster.
Turn on safe mode.
'U'nload the ammunition belt.
Monster will round the corner and attack a large number of times before the layer has an opportunity to act.

Thnaks to vipchess for reporting: https://discourse.cataclysmdda.org/t/is-there-something-wrong-about-the-ammo-belt/15257

[kevingranade]

Fix should be straightforward, take the code starting at https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/game.cpp#L10413 and move it to a new activity handler, which will incrementally unload the target magazine or gun without letting player::moves go far into negatives.

There's also an opportunity to resolve #18489 by preventing the player from dropping the magazine while unloading it. (probably just a matter of making sure the casings and ammunition are dropped instead of the magizine or gun)

[Inglonias]

The code referenced in Kevin's comment seems to have moved since... wow. April.

For those who want to take a crack at this, the code he's referring to is now a couple hundred lines up the file, here:
https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/game.cpp#L9856