Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upNon-configureable keys in overmap screen may lead to collisions with user-configured movement keys #235
Comments
This comment has been minimized.
This comment has been minimized.
|
9bc757c but somewhat exists. I tested by mapping west to the ` key, and in the overmap it worked just fine. Mapping 'q' to west is where things went wrong. it will let me move west in the world, but in the map repeats the same issue @Wuzzy2 reported. Seems there's a hardcode use for 'q' in the map that overrides the user keys. |
This comment has been minimized.
This comment has been minimized.
|
There are a few hardcoded overmap keys. (listed in the sidebar). Those should get keymappings as well. These: |
This comment has been minimized.
This comment has been minimized.
|
Those hardcoded keybindings can be changed in data\raw\keybindings.json. But not ingame. (some of the keybindings are for other ingame menus). |
kevingranade
closed this
in
#7283
Apr 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wuzzy2 commentedMar 21, 2013
You can move the overmap with the normal player movement keys just like you move the player. The game respects the user-configured keys. Well ... most of the time.
This bug does not manifest if you use the default movement key bindings.
But you may run into a problem if you changed the movement keybindings. If one of the key is the same as one of the keybindings for the overmap (for example [q] for closing the overmap screen), the game ignores the movement keybinding and uses the overmap keybinding instead.
If you bind “Move Northwest” to [q], the map won’t move Northwest, it will just close.
I discovered the bug by changing the movement keys to:
qwe
asd
yxc
(Note: I use a QWERTZ keyboard)
All keys work except q. It is not possible to move the map with the [q] key. That's not a surprise, as all the other keys do indeed not collide with the overmap special keybindings.
There is nothing the player could possible do anything about this. The player is forced to use another movement key instead.
Here is the behaviour of the game if I bind any of these keys to the movement keys and press one of these in the overmap:
q: overmap keybinding preferred (map closes)
L: movement key is preferred
0: movement key preferred
t: movement key preferred
/: movement key preferred
N: movement key preferred
D: movement key preferred
Esc: I was too lazy to test this.
My suggestion to solve this problem is to simply allow the player to change the bindings in the map screen as well. The movement keys for moving the map still seem OK with me. However, as the overmap bindings are only used in the overmap screen and nowhere else, the game should check only check for collisions with other overmap bindings and the movement keys. The game does not need to check for collisions with other keys. This allows the player to use the key [X](for example) for something in the map screen and for some game-related action at the same time. But this is just a suggestion, I am open for discussion. Do not forget that this issue is mainly a bug report and not an enhanchement request.