New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncraft recipe will yield solder if "using": [ "soldering_standard" ] #25576

Open
cainiaowu opened this Issue Sep 13, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@cainiaowu
Contributor

cainiaowu commented Sep 13, 2018

Describe the bug
Uncraft recipe will yield solder if "using" requirements.

To Reproduce
Steps to reproduce the behavior:

  1. Debug spawn a car alternator, a soldering iron with charge and a toolbox.
  2. Try disassemble the car alternator.
  3. There's solder in the yield list.

Expected behavior
Solder should not in the yield list.
From its description: "A small spool of solder, able to be used in ammunition and electronics."
Melted solder is hard to recover and even if you did you cant get a nice "spool" one.

Screenshots
car alternator:
image

7.5 kw generator:

image

Versions and configuration(please complete the following information):

  • OS: Any
  • Game Version: 0.c-7904
  • Graphics version: Any
  • Mods loaded: Default mod list

Additional context
For reference:


{
  "type": "uncraft",
  "result": "alternator_car",
  "skill_used": "mechanics",
  "difficulty": 3,
  "time": 30000,
  "qualities": [
    { "id": "SCREW", "level": 1 },
    { "id": "WRENCH", "level": 1 },
    { "id": "SAW_M", "level": 1 }
  ],
  "using": [
    [ "soldering_standard", 40 ],
    [ "welding_standard", 10 ]
  ],
  "components": [
    [ [ "power_supply", 1 ] ],
    [ [ "cable", 40 ] ],
    [ [ "bearing", 20 ] ],
    [ [ "scrap", 2 ] ],
    [ [ "steel_chunk", 2 ] ]
  ]
}

{
  "type": "uncraft",
  "result": "generator_7500w",
  "skill_used": "mechanics",
  "difficulty": 4,
  "time": 240000,
  "qualities": [
    { "id": "SCREW", "level": 1 },
    { "id": "WRENCH", "level": 1 },
    { "id": "SAW_M", "level": 1 }
  ],
  "tools": [
    [ [ "soldering_iron", 80 ], [ "toolset", 80 ], [ "oxy_torch", 40 ] ]
  ],
  "components": [
    [ [ "power_supply", 4 ] ],
    [ [ "cable", 400 ] ],
    [ [ "bearing", 80 ] ],
    [ [ "frame", 1 ] ],
    [ [ "scrap", 12 ] ],
    [ [ "steel_chunk", 8 ] ]
  ]
}


@FulcrumA

This comment has been minimized.

Show comment
Hide comment
@FulcrumA

FulcrumA Sep 13, 2018

Contributor

I am unsure. Retrieving at least some of the solder is not an uncommon practice. There's even small handpumps designed just for that purpose when soldering.
Also, it seems you've left some of the template needlessly.

Contributor

FulcrumA commented Sep 13, 2018

I am unsure. Retrieving at least some of the solder is not an uncommon practice. There's even small handpumps designed just for that purpose when soldering.
Also, it seems you've left some of the template needlessly.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Sep 13, 2018

Member

Solder extracted with a suction device is normally discarded, trying to re-use adulterated solder is asking for trouble.

Member

kevingranade commented Sep 13, 2018

Solder extracted with a suction device is normally discarded, trying to re-use adulterated solder is asking for trouble.

@FulcrumA

This comment has been minimized.

Show comment
Hide comment
@FulcrumA

FulcrumA Sep 13, 2018

Contributor

Though in game it really depends on what that solder would be used for - a thing the game doesn't differentiate. I'd reckon making bearings to use in a BB gun would work even with retrieved solder.

Contributor

FulcrumA commented Sep 13, 2018

Though in game it really depends on what that solder would be used for - a thing the game doesn't differentiate. I'd reckon making bearings to use in a BB gun would work even with retrieved solder.

@Mecares

This comment has been minimized.

Show comment
Hide comment
@Mecares

Mecares Sep 13, 2018

Contributor

Looks like it was intended to consume solder to uncraft not yield it.

Contributor

Mecares commented Sep 13, 2018

Looks like it was intended to consume solder to uncraft not yield it.

@FulcrumA

This comment has been minimized.

Show comment
Hide comment
@FulcrumA

FulcrumA Sep 13, 2018

Contributor

That doesn't seem sensible either. You wouldn't need to solder anything to take it apart. Soldering is for connecting various bits.

Contributor

FulcrumA commented Sep 13, 2018

That doesn't seem sensible either. You wouldn't need to solder anything to take it apart. Soldering is for connecting various bits.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Sep 15, 2018

Member
Member

kevingranade commented Sep 15, 2018

@FulcrumA

This comment has been minimized.

Show comment
Hide comment
@FulcrumA

FulcrumA Sep 16, 2018

Contributor

Yes, you use the soldering iron tool, but you don't use additional solder to disassemble stuff.

Contributor

FulcrumA commented Sep 16, 2018

Yes, you use the soldering iron tool, but you don't use additional solder to disassemble stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment