New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Dialogger still needed? #26055

Closed
rtizzy opened this Issue Oct 4, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@rtizzy
Contributor

rtizzy commented Oct 4, 2018

Is your feature request related to a problem? Please describe.
You need Dialogger configured and installed

https://github.com/CleverRaven/Cataclysm-DDA/projects/21#card-12730154

Describe the solution you'd like

I will need access to the current web server or the desired webserver, preferably via SSH.

I can setup something like cataclysmdda.com/dialogger or similar.

Describe alternatives you've considered
You can do this yourself. It would probably take longer to give me access than for you to install it.

Alternatively, their last commit seemed to indicate it can simply be run from Desktop now.

etodd/Lemma@063424b

Additional context
Add any other context (such as mock-ups, proof of concepts or screenshots) about the feature request here.

@mlangsdorf

This comment has been minimized.

Show comment
Hide comment
@mlangsdorf

mlangsdorf Oct 4, 2018

Contributor

I'm in the process of moving most dialogue into JSON (and adding the necessary support code), see #25432.

Dialogger support would be a nice to have if it can spit out CDDA compatible JSON.

Contributor

mlangsdorf commented Oct 4, 2018

I'm in the process of moving most dialogue into JSON (and adding the necessary support code), see #25432.

Dialogger support would be a nice to have if it can spit out CDDA compatible JSON.

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 4, 2018

Member

The goal is to have a publicly-accessable instance for our project to use (meaning a local instance isn't so nice), I took a stab at forking it here: https://github.com/CleverRaven/dialogger which gets served from here https://cleverraven.github.io/dialogger/
We need to specialize it a bit to get it working with DDA's particular dialect of dialog trees, and the much more invasive thing is it looks like it'd be very nice to bump the version of JointJS, which looks non-trivial.

Member

kevingranade commented Oct 4, 2018

The goal is to have a publicly-accessable instance for our project to use (meaning a local instance isn't so nice), I took a stab at forking it here: https://github.com/CleverRaven/dialogger which gets served from here https://cleverraven.github.io/dialogger/
We need to specialize it a bit to get it working with DDA's particular dialect of dialog trees, and the much more invasive thing is it looks like it'd be very nice to bump the version of JointJS, which looks non-trivial.

@rtizzy

This comment has been minimized.

Show comment
Hide comment
@rtizzy

rtizzy Oct 5, 2018

Contributor

@kevingranade

Thanks for the deets.

If you aren't aware , Hacktober fest is currently going on.

https://hacktoberfest.digitalocean.com/

It would likely be a good idea to mark some issues or PRs as "newbie friendly" or similar as it could help bring in a lot of people to help with the project.

I'd say Web Developers are generally more common than C & C++ devs so you can likely find someone to handle the Dialogger conversion relatively easily.

Contributor

rtizzy commented Oct 5, 2018

@kevingranade

Thanks for the deets.

If you aren't aware , Hacktober fest is currently going on.

https://hacktoberfest.digitalocean.com/

It would likely be a good idea to mark some issues or PRs as "newbie friendly" or similar as it could help bring in a lot of people to help with the project.

I'd say Web Developers are generally more common than C & C++ devs so you can likely find someone to handle the Dialogger conversion relatively easily.

@mlangsdorf

This comment has been minimized.

Show comment
Hide comment
@mlangsdorf

mlangsdorf Oct 11, 2018

Contributor

So what's the next step?

Contributor

mlangsdorf commented Oct 11, 2018

So what's the next step?

@kevingranade

This comment has been minimized.

Show comment
Hide comment
@kevingranade

kevingranade Oct 11, 2018

Member

This CleverRaven/dialogger#1 is the only mandatory issue, with that done we'd have a functional UI for editing dialog trees.

Member

kevingranade commented Oct 11, 2018

This CleverRaven/dialogger#1 is the only mandatory issue, with that done we'd have a functional UI for editing dialog trees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment