New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadir is mandatory after a make install #26094

Open
pierredavidbelanger opened this Issue Oct 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@pierredavidbelanger
Contributor

pierredavidbelanger commented Oct 6, 2018

Describe the bug

After make install, I expect the game to know where its data is located, but this is not the case.

To Reproduce

Get the latest git version and build it like this:

pbelanger@marvin:~/dev/Cataclysm-DDA$ sudo make clean
pbelanger@marvin:~/dev/Cataclysm-DDA$ sudo time make install -j12 \
    NATIVE=linux64 \
    RELEASE=1 \
    LTO=1 \
    LOCALIZE=0 \
    USE_HOME_DIR=1 \
    TILES=1 \
    SOUND=1

then go outside of the build folder and execute:

pbelanger@marvin:~$ cataclysm-tiles 
Failed to read from "data/names/en.json": opening file failed
Aborted

But if I specify the --datadir it works:

pbelanger@marvin:~$ cataclysm-tiles --datadir /share/cataclysm-dda/

Expected behavior

I expect the installed version to know where its data is located

Versions and configuration(please complete the following information):

pbelanger@marvin:~$ uname -a
Linux marvin 4.18.0-2-amd64 #1 SMP Debian 4.18.10-1 (2018-09-30) x86_64 GNU/Linux
@pierredavidbelanger

This comment has been minimized.

Show comment
Hide comment
@pierredavidbelanger

pierredavidbelanger Oct 7, 2018

Contributor

OMG, ok, I found a way to make this work, I needed to add an explicit PREFIX=/usr/ define, that way we enter this ifdef required to automatically set the basepath.

I do not close this issue, in case someone want to fix this obscure workaround.

Contributor

pierredavidbelanger commented Oct 7, 2018

OMG, ok, I found a way to make this work, I needed to add an explicit PREFIX=/usr/ define, that way we enter this ifdef required to automatically set the basepath.

I do not close this issue, in case someone want to fix this obscure workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment