Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
It takes too long time to move rags #26107
Describe the bug
Versions and configuration(please complete the following information):
referenced this issue
Oct 7, 2018
Without that fix, moving 10000 rags is the same as moving 1 with Advanced Inventory, which also is nonsense. Note that the fix did not affect "normal" pickup/drop with, so the reported "with [d]/[,] keys, drop/pickup 100 rags = 9m" was like this before.
I think the comprehensive fix we need for item move cost should add consistency in cost between methods (e.g. Advanced Inventory vs drop/pickup actions) and make it simulate bulk item moving:
The move costs should be consistent in the following cases (but we should probably keep that dropping is cheaper than picking up):
Indeed, "normal" pickup/drop (
So as has already been suggested we should make
since picking up actually includes organizing stuff into your inventory (it is not picking something up to your hands).
Bulk item moving
And now to actually solve this bug! Now that all item moving/picking/dropping is handled by activities, at the time the game processes them we have the full list of items to process, so we can optimize and simulate that the player does sensible bulk moving, even mixing different stacks of items. We can just go through this list and fill up "an armful" (5 liters? Larger items are dealt with one at a time) of items and calculated the move cost for that (I guess current
Thoughts? If this idea looks like the way to go, I could try to have a look (it looks pretty daunting though!).