New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magazine-containing items show wrong encumbrance values in description #26109

Open
vetall812 opened this Issue Oct 7, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@vetall812

vetall812 commented Oct 7, 2018

Describe the bug
Items such as "magazine bandolier" or "chest rig" shows encumberance (current) and encumberance when full. But in fact last value doesnt correspond with description.

To Reproduce

  1. Chest rig (empty) shows: 2 | 2 (enc. curr | enc. when full)
  2. Chest rig (w\4 mags) shows: 6 | 2

Expected behavior

  1. Chest rig (empty) shows: 2 | 6 (enc. curr | enc. when full)
  2. Chest rig (w\4 mags) shows: 6 | 6

Versions and configuration(please complete the following information):

  • OS: Windows 10
  • Game Version 0.C-3318-gd692d74

@vetall812 vetall812 changed the title from magazine containing itmes shows encumberance incorrctly in descripton to magazine containing itmes shows wrong encumberance values in descripton Oct 7, 2018

@jbytheway

This comment has been minimized.

Show comment
Hide comment
@jbytheway

jbytheway Oct 7, 2018

Contributor

I added the code to show encumbrance when full. I suspect it only handles liquids properly. Will look into this case. Thanks for reporting :).

Contributor

jbytheway commented Oct 7, 2018

I added the code to show encumbrance when full. I suspect it only handles liquids properly. Will look into this case. Thanks for reporting :).

@Leland Leland changed the title from magazine containing itmes shows wrong encumberance values in descripton to Magazine-containing items show wrong encumbrance values in description Oct 8, 2018

jbytheway added a commit to jbytheway/Cataclysm-DDA that referenced this issue Oct 10, 2018

Calculate max encumbrance for holsters
Holster items (which includes some ammo containers) were not reporting
their max encumbrance correctly because their capacity was not taken
into account.

Fixes CleverRaven#26109.

@jbytheway jbytheway referenced a pull request that will close this issue Oct 10, 2018

Open

More container description improvements #26165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment